From c604f73dde75dc3e3a5053b4641d2eba633c19d8 Mon Sep 17 00:00:00 2001 From: Amir Saeid Date: Tue, 12 Jun 2018 08:43:14 +0100 Subject: [PATCH] Close tmpfile before removing it Also replace tmpfile.Write with io.Copy --- pkg/downloader/chart_downloader.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/downloader/chart_downloader.go b/pkg/downloader/chart_downloader.go index 62553faa1..2e98107e6 100644 --- a/pkg/downloader/chart_downloader.go +++ b/pkg/downloader/chart_downloader.go @@ -102,6 +102,7 @@ func (c *ChartDownloader) DownloadTo(ref, version, dest string) (string, *proven defer func() { if tmpfile != nil { if _, err := os.Stat(tmpfile.Name()); err == nil { + tmpfile.Close() os.Remove(tmpfile.Name()) } } @@ -111,7 +112,7 @@ func (c *ChartDownloader) DownloadTo(ref, version, dest string) (string, *proven } tmpfilename := tmpfile.Name() - if _, err := tmpfile.Write(data.Bytes()); err != nil { + if _, err := io.Copy(tmpfile, data); err != nil { return tmpfilename, nil, err } if err := tmpfile.Close(); err != nil {