From c405e86cd7ba1346ccecfe8e431d1d1709116f15 Mon Sep 17 00:00:00 2001 From: wuhuizuo Date: Tue, 11 May 2021 13:29:08 +0000 Subject: [PATCH] fix(pkg/action): Configuration.Init should not panic Since the method have a error type return value, it should not panic in method body. Signed-off-by: wuhuizuo --- pkg/action/action.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/action/action.go b/pkg/action/action.go index 38ba638e4..d92c9e4d7 100644 --- a/pkg/action/action.go +++ b/pkg/action/action.go @@ -403,12 +403,12 @@ func (c *Configuration) Init(getter genericclioptions.RESTClientGetter, namespac namespace, ) if err != nil { - panic(fmt.Sprintf("Unable to instantiate SQL driver: %v", err)) + return errors.Wrap(err, "Unable to instantiate SQL driver") } store = storage.Init(d) default: // Not sure what to do here. - panic("Unknown driver in HELM_DRIVER: " + helmDriver) + errors.Errorf("Unknown driver in HELM_DRIVER: %s", helmDriver) } c.RESTClientGetter = getter