diff --git a/cmd/helm/helm_test.go b/cmd/helm/helm_test.go index 5e59c41ed..ca49cbc69 100644 --- a/cmd/helm/helm_test.go +++ b/cmd/helm/helm_test.go @@ -111,7 +111,7 @@ func executeActionCommandStdinC(store *storage.Storage, in *os.File, cmd string) actionConfig := &action.Configuration{ Releases: store, KubeClient: &kubefake.PrintingKubeClient{Out: ioutil.Discard}, - Capabilities: chartutil.DefaultCapabilities, + Capabilities: chartutil.DefaultCapabilities(), Log: func(format string, v ...interface{}) {}, } diff --git a/pkg/action/action.go b/pkg/action/action.go index 38ba638e4..eeb433bde 100644 --- a/pkg/action/action.go +++ b/pkg/action/action.go @@ -310,7 +310,7 @@ func (c *Configuration) releaseContent(name string, version int) (*release.Relea func GetVersionSet(client discovery.ServerResourcesInterface) (chartutil.VersionSet, error) { groups, resources, err := client.ServerGroupsAndResources() if err != nil && !discovery.IsGroupDiscoveryFailedError(err) { - return chartutil.DefaultVersionSet, errors.Wrap(err, "could not get apiVersions from Kubernetes") + return chartutil.DefaultVersionSet(), errors.Wrap(err, "could not get apiVersions from Kubernetes") } // FIXME: The Kubernetes test fixture for cli appears to always return nil @@ -318,7 +318,7 @@ func GetVersionSet(client discovery.ServerResourcesInterface) (chartutil.Version // return the default API list. This is also a safe value to return in any // other odd-ball case. if len(groups) == 0 && len(resources) == 0 { - return chartutil.DefaultVersionSet, nil + return chartutil.DefaultVersionSet(), nil } versionMap := make(map[string]interface{}) diff --git a/pkg/action/action_test.go b/pkg/action/action_test.go index fedf260fb..2257330a2 100644 --- a/pkg/action/action_test.go +++ b/pkg/action/action_test.go @@ -83,7 +83,7 @@ func actionConfigFixture(t *testing.T) *Configuration { return &Configuration{ Releases: storage.Init(driver.NewMemory()), KubeClient: &kubefake.FailingKubeClient{PrintingKubeClient: kubefake.PrintingKubeClient{Out: ioutil.Discard}}, - Capabilities: chartutil.DefaultCapabilities, + Capabilities: chartutil.DefaultCapabilities(), RegistryClient: registryClient, Log: func(format string, v ...interface{}) { t.Helper() diff --git a/pkg/action/install.go b/pkg/action/install.go index 4de0b64e6..1c50920de 100644 --- a/pkg/action/install.go +++ b/pkg/action/install.go @@ -196,7 +196,7 @@ func (i *Install) Run(chrt *chart.Chart, vals map[string]interface{}) (*release. if i.ClientOnly { // Add mock objects in here so it doesn't use Kube API server // NOTE(bacongobbler): used for `helm template` - i.cfg.Capabilities = chartutil.DefaultCapabilities + i.cfg.Capabilities = chartutil.DefaultCapabilities() i.cfg.Capabilities.APIVersions = append(i.cfg.Capabilities.APIVersions, i.APIVersions...) i.cfg.KubeClient = &kubefake.PrintingKubeClient{Out: ioutil.Discard} diff --git a/pkg/action/install_test.go b/pkg/action/install_test.go index 63383d778..32f36991f 100644 --- a/pkg/action/install_test.go +++ b/pkg/action/install_test.go @@ -118,7 +118,7 @@ func TestInstallReleaseClientOnly(t *testing.T) { instAction.ClientOnly = true instAction.Run(buildChart(), nil) // disregard output - is.Equal(instAction.cfg.Capabilities, chartutil.DefaultCapabilities) + is.Equal(instAction.cfg.Capabilities, chartutil.DefaultCapabilities()) is.Equal(instAction.cfg.KubeClient, &kubefake.PrintingKubeClient{Out: ioutil.Discard}) } diff --git a/pkg/chartutil/values.go b/pkg/chartutil/values.go index e1cdf4642..96bf98431 100644 --- a/pkg/chartutil/values.go +++ b/pkg/chartutil/values.go @@ -136,7 +136,7 @@ type ReleaseOptions struct { // This takes both ReleaseOptions and Capabilities to merge into the render values. func ToRenderValues(chrt *chart.Chart, chrtVals map[string]interface{}, options ReleaseOptions, caps *Capabilities) (Values, error) { if caps == nil { - caps = DefaultCapabilities + caps = DefaultCapabilities() } top := map[string]interface{}{ "Chart": chrt.Metadata,