From be99ebe8af768b5e83892771c0eccdaa329771d9 Mon Sep 17 00:00:00 2001 From: Tapas Kapadia Date: Mon, 16 Jan 2023 16:10:25 -0600 Subject: [PATCH] feat(helm): add ability for --dry-run to do lookup functions When a helm command is run with the --dry-run flag, it will try to connect to the cluster if the value is 'server' to be able to render lookup functions. Closes #8137 Signed-off-by: Tapas Kapadia --- pkg/action/install.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/pkg/action/install.go b/pkg/action/install.go index f1c9176fc..4d3e6ce6d 100644 --- a/pkg/action/install.go +++ b/pkg/action/install.go @@ -259,10 +259,7 @@ func (i *Install) RunWithContext(ctx context.Context, chrt *chart.Chart, vals ma rel := i.createRelease(chrt, vals) var manifestDoc *bytes.Buffer - // Determines whether `helm template` was used or another command with the --dry-run flag - // as they both set the Install.DryRun field to `true`. The `--dry-run` flag should be able - // to connect to remote for the lookup function. `helm template` is the only command that - // Install.APIVersions field will not be nil. + rel.Hooks, manifestDoc, rel.Info.Notes, err = i.cfg.renderResources(chrt, valuesToRender, i.ReleaseName, i.OutputDir, i.SubNotes, i.UseReleaseName, i.IncludeCRDs, i.PostRenderer, i.DryRun) // Even for errors, attach this if available if manifestDoc != nil {