From be7d393e76f81c363e79cec94902d76674328c4f Mon Sep 17 00:00:00 2001 From: Evans Mungai Date: Thu, 20 Mar 2025 19:24:37 +0000 Subject: [PATCH] fix failing tests Signed-off-by: Evans Mungai --- pkg/downloader/chart_downloader_test.go | 6 ++++++ pkg/registry/client.go | 1 + 2 files changed, 7 insertions(+) diff --git a/pkg/downloader/chart_downloader_test.go b/pkg/downloader/chart_downloader_test.go index 0762650cf..227ca2398 100644 --- a/pkg/downloader/chart_downloader_test.go +++ b/pkg/downloader/chart_downloader_test.go @@ -21,10 +21,12 @@ import ( "testing" "github.com/stretchr/testify/assert" + "github.com/stretchr/testify/require" "helm.sh/helm/v4/internal/test/ensure" "helm.sh/helm/v4/pkg/cli" "helm.sh/helm/v4/pkg/getter" + "helm.sh/helm/v4/pkg/registry" "helm.sh/helm/v4/pkg/repo" "helm.sh/helm/v4/pkg/repo/repotest" ) @@ -61,10 +63,14 @@ func TestResolveChartRef(t *testing.T) { {name: "oci ref with sha256 and version mismatch", ref: "oci://example.com/install/by/sha:0.1.1@sha256:d234555386402a5867ef0169fefe5486858b6d8d209eaf32fd26d29b16807fd6", version: "0.1.2", fail: true}, } + registryClient, err := registry.NewClient() + require.NoError(t, err) + c := ChartDownloader{ Out: os.Stderr, RepositoryConfig: repoConfig, RepositoryCache: repoCache, + RegistryClient: registryClient, Getters: getter.All(&cli.EnvSettings{ RepositoryConfig: repoConfig, RepositoryCache: repoCache, diff --git a/pkg/registry/client.go b/pkg/registry/client.go index 6c571ef4e..302a6ed37 100644 --- a/pkg/registry/client.go +++ b/pkg/registry/client.go @@ -781,6 +781,7 @@ func (c *Client) Tags(ref string) ([]string, error) { if err != nil { return nil, err } + repository.PlainHTTP = c.plainHTTP repository.Client = c.authorizer