From bb8471c5e81fe3f60b8e852dfece61857a20f14e Mon Sep 17 00:00:00 2001 From: flyer103 Date: Sun, 8 Oct 2017 03:50:51 +0800 Subject: [PATCH] fix(tiller): delete Job objects after CronJob object deleted `CronJob` object will create `Job` object(s) to run and when the `CronJob` object is deleted, the related `Job` objects should be deleted cascade. --- pkg/kube/client.go | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/pkg/kube/client.go b/pkg/kube/client.go index a642ebc05..fd9308efe 100644 --- a/pkg/kube/client.go +++ b/pkg/kube/client.go @@ -374,7 +374,14 @@ func deleteResource(c *Client, info *resource.Info) error { if err != nil { // If there is no reaper for this resources, delete it. if kubectl.IsNoSuchReaperError(err) { - return resource.NewHelper(info.Client, info.Mapping).Delete(info.Namespace, info.Name) + propagationPolicy := metav1.DeletePropagationBackground + return resource.NewHelper(info.Client, info.Mapping).DeleteWithOptions( + info.Namespace, + info.Name, + &metav1.DeleteOptions{ + PropagationPolicy: &propagationPolicy, + }, + ) } return err }