From b4fc1c7cb24ac44d20ecd4f8d4add6cb0ffbad93 Mon Sep 17 00:00:00 2001 From: tyrannasaurusbanks Date: Thu, 25 May 2017 17:13:55 +0100 Subject: [PATCH] Add check to ensure helm doesnt 'wait' for external services to become 'ready' --- pkg/kube/wait.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pkg/kube/wait.go b/pkg/kube/wait.go index 9a75add60..960e06bf2 100644 --- a/pkg/kube/wait.go +++ b/pkg/kube/wait.go @@ -136,6 +136,11 @@ func podsReady(pods []v1.Pod) bool { func servicesReady(svc []v1.Service) bool { for _, s := range svc { + // ExternalName Services are external to cluster so helm shouldn't be checking to see if they're 'ready' (i.e. have an IP Set) + if s.Spec.Type == v1.ServiceTypeExternalName { + continue + } + // Make sure the service is not explicitly set to "None" before checking the IP if s.Spec.ClusterIP != v1.ClusterIPNone && !v1.IsServiceIPSet(&s) { return false