From b45875cbbe0d99dae1d57bb80624bd3ec698b1b9 Mon Sep 17 00:00:00 2001 From: Vinaychinnu Date: Sat, 27 Dec 2025 14:55:31 +0530 Subject: [PATCH] Improve error message for invalid --set-json input Signed-off-by: Vinaychinnu --- pkg/cli/values/options.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/cli/values/options.go b/pkg/cli/values/options.go index cd65fa885..2c7156e9a 100644 --- a/pkg/cli/values/options.go +++ b/pkg/cli/values/options.go @@ -66,13 +66,13 @@ func (opts *Options) MergeValues(p getter.Providers) (map[string]interface{}, er // If value is JSON object format, parse it as map var jsonMap map[string]interface{} if err := json.Unmarshal([]byte(trimmedValue), &jsonMap); err != nil { - return nil, fmt.Errorf("failed parsing --set-json data JSON: %s", value) + return nil, fmt.Errorf("failed parsing --set-json data %q: expected valid JSON", value) } base = loader.MergeMaps(base, jsonMap) } else { // Otherwise, parse it as key=value format if err := strvals.ParseJSON(value, base); err != nil { - return nil, fmt.Errorf("failed parsing --set-json data %s", value) + return nil, fmt.Errorf("failed parsing --set-json data %q: expected valid JSON", value) } } }