From a1f5955a652c34b5629a7706b092b215663c85f9 Mon Sep 17 00:00:00 2001 From: Matt Butcher Date: Mon, 17 Oct 2016 17:01:56 -0600 Subject: [PATCH] fix(tiller): fix nil pointers in error messages There were a few places where error messages were accessing properties of objects that were nil because of the error. Closes #1374 --- pkg/storage/driver/cfgmaps.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/storage/driver/cfgmaps.go b/pkg/storage/driver/cfgmaps.go index f33142729..1a0faa350 100644 --- a/pkg/storage/driver/cfgmaps.go +++ b/pkg/storage/driver/cfgmaps.go @@ -100,7 +100,7 @@ func (cfgmaps *ConfigMaps) List(filter func(*rspb.Release) bool) ([]*rspb.Releas for _, item := range list.Items { rls, err := decodeRelease(item.Data["release"]) if err != nil { - logerrf(err, "list: failed to decode release: %s", rls) + logerrf(err, "list: failed to decode release: %v", item) continue } if filter(rls) { @@ -201,7 +201,7 @@ func (cfgmaps *ConfigMaps) Delete(key string) (rls *rspb.Release, err error) { return nil, ErrReleaseNotFound } - logerrf(err, "delete: failed to get release %q", rls.Name) + logerrf(err, "delete: failed to get release %q", key) return nil, err } // delete the release