From b290247efac20245fbc58e372d6aad670782a9de Mon Sep 17 00:00:00 2001
From: Matt Butcher <matt.butcher@microsoft.com>
Date: Thu, 15 Nov 2018 13:15:41 -0700
Subject: [PATCH] ref: rename inspect to show (#4927)

Per the Helm 3 plan, `helm inspect` and all of its subcommands have been moved to `helm show`.

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
---
 cmd/helm/root.go                           |  2 +-
 cmd/helm/{inspect.go => show.go}           | 41 +++++++++++-----------
 cmd/helm/{inspect_test.go => show_test.go} |  6 ++--
 3 files changed, 25 insertions(+), 24 deletions(-)
 rename cmd/helm/{inspect.go => show.go} (84%)
 rename cmd/helm/{inspect_test.go => show_test.go} (96%)

diff --git a/cmd/helm/root.go b/cmd/helm/root.go
index 96d37173a..1aef4b405 100644
--- a/cmd/helm/root.go
+++ b/cmd/helm/root.go
@@ -63,7 +63,7 @@ func newRootCmd(c helm.Interface, out io.Writer, args []string) *cobra.Command {
 		newCreateCmd(out),
 		newDependencyCmd(out),
 		newPullCmd(out),
-		newInspectCmd(out),
+		newShowCmd(out),
 		newLintCmd(out),
 		newPackageCmd(out),
 		newRepoCmd(out),
diff --git a/cmd/helm/inspect.go b/cmd/helm/show.go
similarity index 84%
rename from cmd/helm/inspect.go
rename to cmd/helm/show.go
index 5b4872492..491477922 100644
--- a/cmd/helm/inspect.go
+++ b/cmd/helm/show.go
@@ -29,19 +29,19 @@ import (
 	"k8s.io/helm/pkg/chart/loader"
 )
 
-const inspectDesc = `
+const showDesc = `
 This command inspects a chart and displays information. It takes a chart reference
 ('stable/drupal'), a full path to a directory or packaged chart, or a URL.
 
 Inspect prints the contents of the Chart.yaml file and the values.yaml file.
 `
 
-const inspectValuesDesc = `
+const showValuesDesc = `
 This command inspects a chart (directory, file, or URL) and displays the contents
 of the values.yaml file
 `
 
-const inspectChartDesc = `
+const showChartDesc = `
 This command inspects a chart (directory, file, or URL) and displays the contents
 of the Charts.yaml file
 `
@@ -51,7 +51,7 @@ This command inspects a chart (directory, file, or URL) and displays the content
 of the README file
 `
 
-type inspectOptions struct {
+type showOptions struct {
 	chartpath string
 	output    string
 
@@ -67,14 +67,15 @@ const (
 
 var readmeFileNames = []string{"readme.md", "readme.txt", "readme"}
 
-func newInspectCmd(out io.Writer) *cobra.Command {
-	o := &inspectOptions{output: all}
+func newShowCmd(out io.Writer) *cobra.Command {
+	o := &showOptions{output: all}
 
-	inspectCommand := &cobra.Command{
-		Use:   "inspect [CHART]",
-		Short: "inspect a chart",
-		Long:  inspectDesc,
-		Args:  require.ExactArgs(1),
+	showCommand := &cobra.Command{
+		Use:     "show [CHART]",
+		Short:   "inspect a chart",
+		Aliases: []string{"inspect"},
+		Long:    showDesc,
+		Args:    require.ExactArgs(1),
 		RunE: func(cmd *cobra.Command, args []string) error {
 			cp, err := o.locateChart(args[0])
 			if err != nil {
@@ -87,8 +88,8 @@ func newInspectCmd(out io.Writer) *cobra.Command {
 
 	valuesSubCmd := &cobra.Command{
 		Use:   "values [CHART]",
-		Short: "shows inspect values",
-		Long:  inspectValuesDesc,
+		Short: "shows values for this chart",
+		Long:  showValuesDesc,
 		Args:  require.ExactArgs(1),
 		RunE: func(cmd *cobra.Command, args []string) error {
 			o.output = valuesOnly
@@ -103,8 +104,8 @@ func newInspectCmd(out io.Writer) *cobra.Command {
 
 	chartSubCmd := &cobra.Command{
 		Use:   "chart [CHART]",
-		Short: "shows inspect chart",
-		Long:  inspectChartDesc,
+		Short: "shows the chart",
+		Long:  showChartDesc,
 		Args:  require.ExactArgs(1),
 		RunE: func(cmd *cobra.Command, args []string) error {
 			o.output = chartOnly
@@ -119,7 +120,7 @@ func newInspectCmd(out io.Writer) *cobra.Command {
 
 	readmeSubCmd := &cobra.Command{
 		Use:   "readme [CHART]",
-		Short: "shows inspect readme",
+		Short: "shows the chart's README",
 		Long:  readmeChartDesc,
 		Args:  require.ExactArgs(1),
 		RunE: func(cmd *cobra.Command, args []string) error {
@@ -133,19 +134,19 @@ func newInspectCmd(out io.Writer) *cobra.Command {
 		},
 	}
 
-	cmds := []*cobra.Command{inspectCommand, readmeSubCmd, valuesSubCmd, chartSubCmd}
+	cmds := []*cobra.Command{showCommand, readmeSubCmd, valuesSubCmd, chartSubCmd}
 	for _, subCmd := range cmds {
 		o.chartPathOptions.addFlags(subCmd.Flags())
 	}
 
 	for _, subCmd := range cmds[1:] {
-		inspectCommand.AddCommand(subCmd)
+		showCommand.AddCommand(subCmd)
 	}
 
-	return inspectCommand
+	return showCommand
 }
 
-func (i *inspectOptions) run(out io.Writer) error {
+func (i *showOptions) run(out io.Writer) error {
 	chrt, err := loader.Load(i.chartpath)
 	if err != nil {
 		return err
diff --git a/cmd/helm/inspect_test.go b/cmd/helm/show_test.go
similarity index 96%
rename from cmd/helm/inspect_test.go
rename to cmd/helm/show_test.go
index 405102160..1da5c630d 100644
--- a/cmd/helm/inspect_test.go
+++ b/cmd/helm/show_test.go
@@ -23,10 +23,10 @@ import (
 	"testing"
 )
 
-func TestInspect(t *testing.T) {
+func TestShow(t *testing.T) {
 	b := bytes.NewBuffer(nil)
 
-	o := &inspectOptions{
+	o := &showOptions{
 		chartpath: "testdata/testcharts/alpine",
 		output:    all,
 	}
@@ -67,7 +67,7 @@ func TestInspect(t *testing.T) {
 
 	// Regression tests for missing values. See issue #1024.
 	b.Reset()
-	o = &inspectOptions{
+	o = &showOptions{
 		chartpath: "testdata/testcharts/novals",
 		output:    "values",
 	}