diff --git a/pkg/helm/helm_test.go b/pkg/helm/helm_test.go index bcaeec2f0..1ae5b33bf 100644 --- a/pkg/helm/helm_test.go +++ b/pkg/helm/helm_test.go @@ -285,7 +285,7 @@ func TestReleaseStatus_VerifyOptions(t *testing.T) { return errSkip }) - if _, err := NewClient(b4c).ReleaseStatus(releaseName, StatusReleaseVersion(revision)); err != errSkip { + if _, err := NewClient(b4c).ReleaseStatus(releaseName, StatusReleaseVersion(revision,"","")); err != errSkip { t.Fatalf("did not expect error but got (%v)\n``", err) } } diff --git a/pkg/kube/client_test.go b/pkg/kube/client_test.go index 1f2032bb2..623cc86f6 100644 --- a/pkg/kube/client_test.go +++ b/pkg/kube/client_test.go @@ -323,8 +323,9 @@ func TestGet(t *testing.T) { c := &Client{Factory: f} // Test Success + var filter FilterStruct data := strings.NewReader("kind: Pod\napiVersion: v1\nmetadata:\n name: otter") - o, err := c.Get("default", data) + o, err := c.Get("default", data,filter) if err != nil { t.Errorf("Expected missing results, got %q", err) } @@ -334,7 +335,7 @@ func TestGet(t *testing.T) { // Test failure data = strings.NewReader("kind: Pod\napiVersion: v1\nmetadata:\n name: starfish") - o, err = c.Get("default", data) + o, err = c.Get("default", data,filter) if err != nil { t.Errorf("Expected missing results, got %q", err) } diff --git a/pkg/releasetesting/environment_test.go b/pkg/releasetesting/environment_test.go index deb8617f6..d0cc3165a 100644 --- a/pkg/releasetesting/environment_test.go +++ b/pkg/releasetesting/environment_test.go @@ -23,6 +23,7 @@ import ( "os" "testing" + "k8s.io/helm/pkg/kube" "k8s.io/helm/pkg/proto/hapi/release" tillerEnv "k8s.io/helm/pkg/tiller/environment" ) @@ -68,8 +69,9 @@ func TestDeleteTestPods(t *testing.T) { t.Errorf("Expected 0 errors, got at least one: %v", stream.messages) } + var filter kube.FilterStruct for _, testManifest := range mockTestSuite.TestManifests { - if _, err := mockTestEnv.KubeClient.Get(mockTestEnv.Namespace, bytes.NewBufferString(testManifest)); err == nil { + if _, err := mockTestEnv.KubeClient.Get(mockTestEnv.Namespace, bytes.NewBufferString(testManifest),filter); err == nil { t.Error("Expected error, got nil") } } @@ -122,7 +124,7 @@ func newGetFailingKubeClient() *getFailingKubeClient { } } -func (p *getFailingKubeClient) Get(ns string, r io.Reader) (string, error) { +func (p *getFailingKubeClient) Get(ns string, r io.Reader,filter kube.FilterStruct) (string, error) { return "", errors.New("In the end, they did not find Nemo.") }