From ad886c5e36abd2b7cdc1d36b4a48ed638847a981 Mon Sep 17 00:00:00 2001 From: Morten Torkildsen Date: Sun, 19 May 2019 08:31:09 -0700 Subject: [PATCH] fix(helm): Disable schema validation for manifests Signed-off-by: Morten Torkildsen --- pkg/kube/client.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/kube/client.go b/pkg/kube/client.go index 36467fad5..dfce2aaff 100644 --- a/pkg/kube/client.go +++ b/pkg/kube/client.go @@ -157,13 +157,16 @@ func (c *Client) BuildUnstructured(namespace string, reader io.Reader) (Result, } // Validate reads Kubernetes manifests and validates the content. +// +// This function does not actually do schema validation of manifests. Adding +// validation now breaks existing clients of helm: https://github.com/helm/helm/issues/5750 func (c *Client) Validate(namespace string, reader io.Reader) error { _, err := c.NewBuilder(). Unstructured(). ContinueOnError(). NamespaceParam(namespace). DefaultNamespace(). - Schema(c.validator()). + // Schema(c.validator()). // No schema validation Stream(reader, ""). Flatten(). Do().Infos()