From aaf0c0974ca677fd9b684bb2b5032985ac89533c Mon Sep 17 00:00:00 2001
From: "Kai A. Hiller" <git@kaialexhiller.de>
Date: Mon, 2 Dec 2024 12:18:25 +0100
Subject: [PATCH] Add negative unittests for nil value rendering

Signed-off-by: Kai A. Hiller <git@kaialexhiller.de>
---
 pkg/engine/engine_test.go | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/pkg/engine/engine_test.go b/pkg/engine/engine_test.go
index 705ee5098..7289ea515 100644
--- a/pkg/engine/engine_test.go
+++ b/pkg/engine/engine_test.go
@@ -1308,10 +1308,15 @@ func TestRenderNilValue(t *testing.T) {
 			Version: "1.2.3",
 		},
 		Templates: []*chart.File{
-			{Name: "templates/_helpers.tpl", Data: []byte(`{{- define "noval" -}}{{ and nil }}{{- end -}}`)},
+			{Name: "templates/_helpers.tpl", Data: []byte(`` +
+				`{{- define "noval" -}}{{ and nil }}{{- end -}}` +
+				`{{- define "noval_str" -}}<no value>{{- end -}}`)},
 			{Name: "templates/test_include.yaml", Data: []byte(`{{ eq (include "noval" .) "" }}`)},
 			{Name: "templates/test_tpl.yaml", Data: []byte(`{{ eq (tpl "{{ and nil }}" .) "" }}`)},
 			{Name: "templates/test_render.yaml", Data: []byte(`{{ and nil }}`)},
+			{Name: "templates/test_include_str.yaml", Data: []byte(`{{ eq (include "noval_str" .) "<no value>" }}`)},
+			{Name: "templates/test_tpl_str.yaml", Data: []byte(`{{ eq (tpl "<no value>" .) "<no value>" }}`)},
+			{Name: "templates/test_render_str.yaml", Data: []byte(`<no value>`)},
 		},
 	}
 
@@ -1321,9 +1326,12 @@ func TestRenderNilValue(t *testing.T) {
 	}
 
 	expect := map[string]string{
-		"moby/templates/test_include.yaml": "true",
-		"moby/templates/test_tpl.yaml":     "true",
-		"moby/templates/test_render.yaml":  "",
+		"moby/templates/test_include.yaml":     "true",
+		"moby/templates/test_tpl.yaml":         "true",
+		"moby/templates/test_render.yaml":      "",
+		"moby/templates/test_include_str.yaml": "true",
+		"moby/templates/test_tpl_str.yaml":     "true",
+		"moby/templates/test_render_str.yaml":  "<no value>",
 	}
 	for name, data := range expect {
 		if out[name] != data {