From aa6a3b11221275bbedcef861981a3eb86c6f8b77 Mon Sep 17 00:00:00 2001 From: Robert James Hernandez Date: Fri, 7 Sep 2018 10:12:24 -0700 Subject: [PATCH] test(helm): Adding case for versions short flag When git sha is empty if being built from tarball running 'helm version --short' should just ignore '--short' since sha is empty. Adding test to ensure this is the case. Signed-off-by: Robert James Hernandez --- cmd/helm/version_test.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/cmd/helm/version_test.go b/cmd/helm/version_test.go index 5519131c2..c1223ef91 100644 --- a/cmd/helm/version_test.go +++ b/cmd/helm/version_test.go @@ -57,6 +57,12 @@ func TestVersion(t *testing.T) { flags: []string{"--template", "{{ .Client.SemVer }} {{ .Server.SemVer }}"}, expected: lver + " " + sver, }, + { + name: "client short empty git", + args: []string{}, + flags: []string{"-c", "--short"}, + expected: lver, + }, } settings.TillerHost = "fake-localhost" runReleaseCases(t, tests, func(c *helm.FakeClient, out io.Writer) *cobra.Command {