From a402e03119b094287f606effe49a36e53f687a8e Mon Sep 17 00:00:00 2001 From: Michael Venezia Date: Thu, 12 Oct 2017 12:47:45 -0400 Subject: [PATCH] Updating per review comments --- docs/charts_tips_and_tricks.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/charts_tips_and_tricks.md b/docs/charts_tips_and_tricks.md index 5d8028417..875a38cf0 100644 --- a/docs/charts_tips_and_tricks.md +++ b/docs/charts_tips_and_tricks.md @@ -111,7 +111,7 @@ You can add a helper like so: ``` {{- define "imagePullSecret" }} -{{- printf "{\n\t\"auths\": {\n\t\t\"%s\": {\n\t\t\t\"auth\": \"%s\"\n\t\t}\n\t}\n}" .Values.imageCredentials.registry (printf "%s:%s" .Values.imageCredentials.username .Values.imageCredentials.password | b64enc) |b64enc }} +{{- printf "{\"auths\": {\"%s\": {\"auth\": \"%s\"}}}" .Values.imageCredentials.registry (printf "%s:%s" .Values.imageCredentials.username .Values.imageCredentials.password | b64enc) | b64enc }} {{- end }} ``` @@ -121,9 +121,9 @@ apiVersion: v1 kind: Secret metadata: name: myregistrykey +type: kubernetes.io/dockerconfigjson data: .dockerconfigjson: {{ template "imagePullSecret" . }} -type: kubernetes.io/dockerconfigjson ``` ## Automatically Roll Deployments When ConfigMaps or Secrets change