From 9e8f8b2821f9d543dd78d11629f7da4e60c0d29f Mon Sep 17 00:00:00 2001 From: Felix Becker Date: Thu, 27 Jan 2022 01:13:29 +0100 Subject: [PATCH] Cleanup httpgetter_test.go Just a small cleanup in the httpgetter_test.go. Remove dead code that can never be reached (ok is always true if a basic auth exists) Signed-off-by: Felix Becker --- pkg/getter/httpgetter_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/getter/httpgetter_test.go b/pkg/getter/httpgetter_test.go index d823aec0d..4c6a82667 100644 --- a/pkg/getter/httpgetter_test.go +++ b/pkg/getter/httpgetter_test.go @@ -208,8 +208,8 @@ func TestDownload(t *testing.T) { // test with Get URL differing from withURL crossAuthSrv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { username, password, ok := r.BasicAuth() - if ok || username == "username" || password == "password" { - t.Errorf("Expected request to not include but got '%v', '%s', '%s'", ok, username, password) + if ok { + t.Errorf("Expected no basic auth in request but got user '%s' and password '%s'", username, password) } fmt.Fprint(w, expect) }))