From 9b2090081feb9c1702bab5142ab3c9ca9aba1498 Mon Sep 17 00:00:00 2001 From: Michelle Noorali Date: Tue, 5 Apr 2016 09:45:19 -0600 Subject: [PATCH] ref(helm/doctor): update error message This resolves issue #558. --- cmd/helm/doctor.go | 2 +- pkg/client/install.go | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/cmd/helm/doctor.go b/cmd/helm/doctor.go index 6afda12ac..5fb8c1e43 100644 --- a/cmd/helm/doctor.go +++ b/cmd/helm/doctor.go @@ -42,7 +42,7 @@ func doctor(c *cli.Context) error { if client.IsInstalled(runner) { format.Success("You have everything you need. Go forth my friend!") } else { - format.Warning("Looks like you don't have DM installed.\nRun: `helm server install`") + format.Warning("Looks like you don't have the helm server-side components installed.\nRun: `helm server install`") } return nil diff --git a/pkg/client/install.go b/pkg/client/install.go index 379dc6025..22a6d5300 100644 --- a/pkg/client/install.go +++ b/pkg/client/install.go @@ -21,7 +21,6 @@ import ( "text/template" "github.com/Masterminds/sprig" - "github.com/kubernetes/helm/pkg/format" "github.com/kubernetes/helm/pkg/kubectl" ) @@ -73,9 +72,8 @@ func (i *Installer) expand() ([]byte, error) { func IsInstalled(runner kubectl.Runner) bool { // Basically, we test "all-or-nothing" here: if this returns without error // we know that we have both the namespace and the manager API server. - out, err := runner.GetByKind("rc", "manager-rc", "helm") + _, err := runner.GetByKind("rc", "manager-rc", "helm") if err != nil { - format.Err("Installation not found: %s %s", out, err) return false } return true