From 9a7d6cb5970288a0d8cd6aa2c29deb02e0f6e5ca Mon Sep 17 00:00:00 2001
From: oilbeater <liumengxinfly@gmail.com>
Date: Sat, 10 Feb 2018 16:58:39 +0800
Subject: [PATCH] defer in loop may cause resource leak

---
 pkg/chartutil/expand.go | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/pkg/chartutil/expand.go b/pkg/chartutil/expand.go
index ae28f8147..126e14e80 100644
--- a/pkg/chartutil/expand.go
+++ b/pkg/chartutil/expand.go
@@ -63,11 +63,12 @@ func Expand(dir string, r io.Reader) error {
 		if err != nil {
 			return err
 		}
-		defer file.Close()
 		_, err = io.Copy(file, tr)
 		if err != nil {
+			file.Close()
 			return err
 		}
+		file.Close()
 	}
 	return nil
 }