From a9a657434a4d08ab3b772f891878caaa52b7bd17 Mon Sep 17 00:00:00 2001 From: Terry Howe Date: Wed, 24 Sep 2025 15:33:15 -0600 Subject: [PATCH] fix: broken --html flag to coverage script Signed-off-by: Terry Howe --- scripts/coverage.sh | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/scripts/coverage.sh b/scripts/coverage.sh index 487d4eeee..9e85a358e 100755 --- a/scripts/coverage.sh +++ b/scripts/coverage.sh @@ -19,7 +19,18 @@ set -euo pipefail covermode=${COVERMODE:-atomic} coverdir=$(mktemp -d /tmp/coverage.XXXXXXXXXX) profile="${coverdir}/cover.out" -target="${1:-./...}" # by default the whole repository is tested +html=false +target="./..." # by default the whole repository is tested +for arg in "$@"; do + case "${arg}" in + --html) + html=true + ;; + *) + target="${arg}" + ;; + esac +done generate_cover_data() { for d in $(go list "$target"); do @@ -36,9 +47,7 @@ generate_cover_data() { generate_cover_data go tool cover -func "${profile}" -case "${1-}" in - --html) +if [ "${html}" == "true" ] ; then go tool cover -html "${profile}" - ;; -esac +fi