From 917822cfca6f146a893e386a788619065626810e Mon Sep 17 00:00:00 2001 From: Terry Howe Date: Fri, 17 Oct 2025 05:08:32 -0600 Subject: [PATCH] refactor: remove unused err from pkg/registry/client.go Signed-off-by: Terry Howe --- pkg/registry/client.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/pkg/registry/client.go b/pkg/registry/client.go index 95250f8da..1cb629657 100644 --- a/pkg/registry/client.go +++ b/pkg/registry/client.go @@ -75,11 +75,11 @@ type ( credentialsStore credentials.Store httpClient *http.Client plainHTTP bool - err error // pass any errors from the ClientOption functions } // ClientOption allows specifying various settings configurable by the user for overriding the defaults // used when creating a new default client + // TODO(TerryHowe): ClientOption should return error in v5 ClientOption func(*Client) ) @@ -90,9 +90,6 @@ func NewClient(options ...ClientOption) (*Client, error) { } for _, option := range options { option(client) - if client.err != nil { - return nil, client.err - } } if client.credentialsFile == "" { client.credentialsFile = helmpath.ConfigPath(CredentialsFileBasename)