From 8e9717cff0ba1e92305e9d10b67dfd3568d92502 Mon Sep 17 00:00:00 2001 From: Andrew Melis Date: Wed, 22 Jul 2020 12:21:30 -0400 Subject: [PATCH] Enhance readability by extracting bitwise operation Fixes https://github.com/helm/helm/pull/8282#discussion_r458368780 Signed-off-by: Andrew Melis (cherry picked from commit f9d35242d0cc3774e4c4d937e6c00c49aa8c6c7f) --- pkg/action/list.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/action/list.go b/pkg/action/list.go index 3d5e6d7a6..0f85de519 100644 --- a/pkg/action/list.go +++ b/pkg/action/list.go @@ -250,7 +250,8 @@ func (l *List) filterStateMask(releases []*release.Release) []*release.Release { for _, rls := range releases { currentStatus := l.StateMask.FromName(rls.Info.Status.String()) - if l.StateMask¤tStatus == 0 { + mask := l.StateMask & currentStatus + if mask == 0 { continue } desiredStateReleases = append(desiredStateReleases, rls)