From 8998efa4c448ac885dde62071aa92c3bafd3d51a Mon Sep 17 00:00:00 2001 From: Yarden Shoham Date: Tue, 17 Sep 2024 22:30:09 +0300 Subject: [PATCH] Lint Signed-off-by: Yarden Shoham --- pkg/cache/cache.go | 19 +++++++++++++++++-- pkg/cache/cache_test.go | 17 ++++++++++++++++- 2 files changed, 33 insertions(+), 3 deletions(-) diff --git a/pkg/cache/cache.go b/pkg/cache/cache.go index b66841ea1..310ed21f2 100644 --- a/pkg/cache/cache.go +++ b/pkg/cache/cache.go @@ -1,3 +1,18 @@ +/* +Copyright The Helm Authors. +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + +http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + package cache import ( @@ -22,9 +37,9 @@ func NewNoOpCache[V any]() *NoOpCache[V] { return &NoOpCache[V]{} } -func (c *NoOpCache[V]) Set(key string, value V) {} +func (c *NoOpCache[V]) Set(_ string, value V) {} -func (c *NoOpCache[V]) Get(key string) (V, bool) { +func (c *NoOpCache[V]) Get(_ string) (V, bool) { var zero V return zero, false } diff --git a/pkg/cache/cache_test.go b/pkg/cache/cache_test.go index 3f7bb7580..06128bd96 100644 --- a/pkg/cache/cache_test.go +++ b/pkg/cache/cache_test.go @@ -1,3 +1,18 @@ +/* +Copyright The Helm Authors. +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + +http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + package cache import ( @@ -9,7 +24,7 @@ import ( func TestNoOpCache(t *testing.T) { cache := NewNoOpCache[string]() - t.Run("Set", func(t *testing.T) { + t.Run("Set", func(_ *testing.T) { cache.Set("key", "value") // No assertion needed as it's a no-op })