From 879461e499b4643d31f25b84bd5e862638d86209 Mon Sep 17 00:00:00 2001 From: Jeremy Schoemaker Date: Tue, 8 Sep 2026 15:31:27 -0500 Subject: [PATCH] fix(helm): update TestSqlUpdate to assert label sync transaction Signed-off-by: Jeremy Schoemaker --- pkg/storage/driver/sql_test.go | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/pkg/storage/driver/sql_test.go b/pkg/storage/driver/sql_test.go index 044e9df7b..6c24ce4a4 100644 --- a/pkg/storage/driver/sql_test.go +++ b/pkg/storage/driver/sql_test.go @@ -309,11 +309,40 @@ func TestSqlUpdate(t *testing.T) { sqlReleaseTableNamespaceColumn, ) + mock.ExpectBegin() mock. ExpectExec(regexp.QuoteMeta(query)). WithArgs(body, rel.Name, int(rel.Version), rel.Info.Status.String(), sqlReleaseDefaultOwner, recentUnixTimestamp(), key, namespace). WillReturnResult(sqlmock.NewResult(0, 1)) + deleteLabelsQuery := fmt.Sprintf( + "DELETE FROM %s WHERE %s = $1 AND %s = $2", + sqlCustomLabelsTableName, + sqlCustomLabelsTableReleaseKeyColumn, + sqlCustomLabelsTableReleaseNamespaceColumn, + ) + mock. + ExpectExec(regexp.QuoteMeta(deleteLabelsQuery)). + WithArgs(key, namespace). + WillReturnResult(sqlmock.NewResult(0, 1)) + + insertLabelsQuery := fmt.Sprintf( + "INSERT INTO %s (%s,%s,%s,%s) VALUES ($1,$2,$3,$4)", + sqlCustomLabelsTableName, + sqlCustomLabelsTableReleaseKeyColumn, + sqlCustomLabelsTableReleaseNamespaceColumn, + sqlCustomLabelsTableKeyColumn, + sqlCustomLabelsTableValueColumn, + ) + mock.MatchExpectationsInOrder(false) + for k, v := range filterSystemLabels(rel.Labels) { + mock. + ExpectExec(regexp.QuoteMeta(insertLabelsQuery)). + WithArgs(key, namespace, k, v). + WillReturnResult(sqlmock.NewResult(0, 1)) + } + mock.ExpectCommit() + require.NoErrorf(t, sqlDriver.Update(key, rel), "failed to update release with key %s", key) assert.NoErrorf(t, mock.ExpectationsWereMet(), "sql expectations weren't met") }