Update best practices on imagePullPolicy

Setting the value of `imagePullPolicy` should be aligned to what `helm create` does
pull/3119/head
Franz Beltran 7 years ago committed by GitHub
parent 648239edc3
commit 85ed9f3d4b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -30,12 +30,21 @@ image: "{{ .Values.redisImage }}:{{ .Values.redisTag }}"
## ImagePullPolicy
The `imagePullPolicy` should default to an empty value, but allow users to override it:
`helm create` sets the `imagePullPolicy` to `IfNotPresent` by default by doing the following in your `deployment.yaml`:
```yaml
imagePullPolicy: {{ default "" .Values.imagePullPolicy | quote }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
```
And `values.yaml`:
```yaml
pullPolicy: IfNotPresent
```
Similarly, Kubernetes defaults the `imagePullPolicy` to `IfNotPresent` if it is not defined at all. If you want a value other than `IfNotPresent`, simply update the value in `values.yaml` to your desired value.
## PodTemplates Should Declare Selectors
All PodTemplate sections should specify a selector. For example:

Loading…
Cancel
Save