diff --git a/cmd/helm/flags.go b/cmd/helm/flags.go index 32d5b891b..a3cf59bae 100644 --- a/cmd/helm/flags.go +++ b/cmd/helm/flags.go @@ -18,6 +18,7 @@ package main import ( "fmt" + "strings" "github.com/spf13/cobra" "github.com/spf13/pflag" @@ -51,7 +52,14 @@ func addChartPathOptionsFlags(f *pflag.FlagSet, c *action.ChartPathOptions) { // bindOutputFlag will add the output flag to the given command and bind the // value to the given format pointer func bindOutputFlag(cmd *cobra.Command, varRef *output.Format) { - cmd.Flags().VarP(newOutputValue(output.Table, varRef), outputFlag, "o", fmt.Sprintf("prints the output in the specified format. Allowed values: %s, %s, %s", output.Table, output.JSON, output.YAML)) + var formats strings.Builder + for index, format := range output.Formats() { + if index != 0 { + formats.WriteString(", ") + } + formats.WriteString(format.String()) + } + cmd.Flags().VarP(newOutputValue(output.Table, varRef), outputFlag, "o", fmt.Sprintf("prints the output in the specified format. Allowed values: %s", formats.String())) // Setup shell completion for the flag cmd.MarkFlagCustom(outputFlag, "__helm_output_options") } diff --git a/cmd/helm/root.go b/cmd/helm/root.go index e28e8bdfb..0fed728e8 100644 --- a/cmd/helm/root.go +++ b/cmd/helm/root.go @@ -17,13 +17,16 @@ limitations under the License. package main // import "helm.sh/helm/v3/cmd/helm" import ( + "fmt" "io" + "strings" "github.com/spf13/cobra" "helm.sh/helm/v3/cmd/helm/require" "helm.sh/helm/v3/internal/experimental/registry" "helm.sh/helm/v3/pkg/action" + "helm.sh/helm/v3/pkg/cli/output" ) const ( @@ -92,7 +95,7 @@ __helm_get_namespaces() __helm_output_options() { __helm_debug "${FUNCNAME[0]}: c is $c words[c] is ${words[c]}" - COMPREPLY+=( $( compgen -W "table json yaml" -- "$cur" ) ) + COMPREPLY+=( $( compgen -W "%[1]s" -- "$cur" ) ) } __helm_binary_name() @@ -203,13 +206,19 @@ By default, the default directories depend on the Operating System. The defaults ` func newRootCmd(actionConfig *action.Configuration, out io.Writer, args []string) *cobra.Command { + var formats strings.Builder + for _, format := range output.Formats() { + formats.WriteString(format.String()) + formats.WriteByte(' ') + } + cmd := &cobra.Command{ Use: "helm", Short: "The Helm package manager for Kubernetes.", Long: globalUsage, SilenceUsage: true, Args: require.NoArgs, - BashCompletionFunction: bashCompletionFunc, + BashCompletionFunction: fmt.Sprintf(bashCompletionFunc, formats.String()), } flags := cmd.PersistentFlags() diff --git a/pkg/cli/output/output.go b/pkg/cli/output/output.go index da9ee63a8..3e6a52a2c 100644 --- a/pkg/cli/output/output.go +++ b/pkg/cli/output/output.go @@ -35,6 +35,11 @@ const ( YAML Format = "yaml" ) +// Formats returns a list of supported formats +func Formats() []Format { + return []Format{Table, JSON, YAML} +} + // ErrInvalidFormatType is returned when an unsupported format type is used var ErrInvalidFormatType = fmt.Errorf("invalid format type")