From 7eb9ca17b7ed11f0db5ed59745c2cfca9c315aef Mon Sep 17 00:00:00 2001 From: akshat09867 Date: Mon, 2 Feb 2026 18:53:07 +0530 Subject: [PATCH] fix: restore missing comments and TODOs in getters Signed-off-by: akshat09867 --- pkg/getter/httpgetter.go | 4 +++- pkg/getter/plugingetter.go | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/pkg/getter/httpgetter.go b/pkg/getter/httpgetter.go index 66ae94d57..9edc666c5 100644 --- a/pkg/getter/httpgetter.go +++ b/pkg/getter/httpgetter.go @@ -133,7 +133,9 @@ func (g *HTTPGetter) httpClient() (*http.Client, error) { g.transport = &http.Transport{ DisableCompression: true, Proxy: http.ProxyFromEnvironment, - TLSClientConfig: &tls.Config{}, + // Being nil would cause the tls.Config default to be used + // "NewTLSConfig" modifies an empty TLS config, not the default one + TLSClientConfig: &tls.Config{}, } }) diff --git a/pkg/getter/plugingetter.go b/pkg/getter/plugingetter.go index 2c76afe3f..52199c685 100644 --- a/pkg/getter/plugingetter.go +++ b/pkg/getter/plugingetter.go @@ -108,6 +108,7 @@ func (g *getterPlugin) Get(href string, options ...Option) (*bytes.Buffer, error env = append(env, "HELM_DEBUG=1") } + // TODO optimization: pass this along to Get() instead of re-parsing here u, err := url.Parse(href) if err != nil { return nil, err @@ -120,6 +121,8 @@ func (g *getterPlugin) Get(href string, options ...Option) (*bytes.Buffer, error Protocol: u.Scheme, }, Env: env, + // TODO should we pass Stdin, Stdout, and Stderr through Input here to getter plugins? + // Stdout: os.Stdout, } output, err := g.plg.Invoke(context.Background(), input) if err != nil {