diff --git a/cmd/helm/repo_add.go b/cmd/helm/repo_add.go index 8844174be..4ddf013c5 100644 --- a/cmd/helm/repo_add.go +++ b/cmd/helm/repo_add.go @@ -177,6 +177,11 @@ func (o *repoAddOptions) run(out io.Writer) error { InsecureSkipTLSverify: o.insecureSkipTLSverify, } + // Check if the repo name is legal + if strings.Contains(o.name, "/") { + return errors.Errorf("repository name (%s) contains '/', please specify a different name without '/'", o.name) + } + // If the repo exists do one of two things: // 1. If the configuration for the name is the same continue without error // 2. When the config is different require --force-update diff --git a/cmd/helm/repo_add_test.go b/cmd/helm/repo_add_test.go index c88479ea1..dabfb2a88 100644 --- a/cmd/helm/repo_add_test.go +++ b/cmd/helm/repo_add_test.go @@ -131,6 +131,39 @@ func TestRepoAdd(t *testing.T) { } } +func TestRepoAddCheckLegalName(t *testing.T) { + ts, err := repotest.NewTempServerWithCleanup(t, "testdata/testserver/*.*") + if err != nil { + t.Fatal(err) + } + defer ts.Stop() + defer resetEnv()() + + const testRepoName = "test-hub/test-name" + + rootDir := ensure.TempDir(t) + repoFile := filepath.Join(ensure.TempDir(t), "repositories.yaml") + + o := &repoAddOptions{ + name: testRepoName, + url: ts.URL(), + forceUpdate: false, + deprecatedNoUpdate: true, + repoFile: repoFile, + } + os.Setenv(xdg.CacheHomeEnvVar, rootDir) + + wantErrorMsg := fmt.Sprintf("repository name (%s) contains '/', please specify a different name without '/'", testRepoName) + + if err := o.run(ioutil.Discard); err != nil { + if wantErrorMsg != err.Error() { + t.Fatalf("Actual error %s, not equal to expected error %s", err, wantErrorMsg) + } + } else { + t.Fatalf("expect reported an error.") + } +} + func TestRepoAddConcurrentGoRoutines(t *testing.T) { const testName = "test-name" repoFile := filepath.Join(ensure.TempDir(t), "repositories.yaml")