Swap to filepath.IsLocal

Signed-off-by: Mark <markleechuyong@gmail.com>
pull/13049/head
Mark 1 year ago
parent 51a07e7e78
commit 7b9c408204

@ -112,7 +112,7 @@ func (md *Metadata) Validate() error {
return ValidationError("chart.metadata.name is required")
}
if md.Name != filepath.Base(md.Name) {
if !filepath.IsLocal(md.Name) {
return ValidationErrorf("chart.metadata.name %q is invalid", md.Name)
}

@ -45,6 +45,11 @@ func TestValidate(t *testing.T) {
&Metadata{Name: "../../test", APIVersion: "v2", Version: "1.0"},
ValidationError("chart.metadata.name \"../../test\" is invalid"),
},
{
"chart without name (namespace)",
&Metadata{Name: "../../namespace/test", APIVersion: "v2", Version: "1.0"},
ValidationError("chart.metadata.name \"../../namespace/test\" is invalid"),
},
{
"chart without version",
&Metadata{Name: "test", APIVersion: "v2"},
@ -177,6 +182,11 @@ func TestValidate(t *testing.T) {
&Metadata{APIVersion: "v2", Name: "test", Version: "1.2.3.4"},
ValidationError("chart.metadata.version \"1.2.3.4\" is invalid"),
},
{
"namespaced chart",
&Metadata{Name: "namespace/test", APIVersion: "v2", Version: "1.0", Type: "application"},
nil,
},
}
for _, tt := range tests {

Loading…
Cancel
Save