From 7a5816b106ae2aca4dc952ca580c09979177d65b Mon Sep 17 00:00:00 2001
From: Evans Mungai <mbuevans@gmail.com>
Date: Tue, 21 Oct 2025 23:53:09 +0100
Subject: [PATCH] Self review changes

Signed-off-by: Evans Mungai <mbuevans@gmail.com>
---
 pkg/action/action.go          | 1 -
 pkg/kube/client.go            | 2 +-
 pkg/storage/driver/cfgmaps.go | 2 +-
 pkg/storage/driver/memory.go  | 2 +-
 pkg/storage/driver/secrets.go | 2 +-
 pkg/storage/driver/sql.go     | 6 +++---
 pkg/storage/storage.go        | 2 +-
 7 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/pkg/action/action.go b/pkg/action/action.go
index 4641b7427..cde915989 100644
--- a/pkg/action/action.go
+++ b/pkg/action/action.go
@@ -530,7 +530,6 @@ func (cfg *Configuration) Init(getter genericclioptions.RESTClientGetter, namesp
 	case "sql":
 		d, err := driver.NewSQL(
 			os.Getenv("HELM_DRIVER_SQL_CONNECTION_STRING"),
-			cfg.Logger(),
 			namespace,
 		)
 		if err != nil {
diff --git a/pkg/kube/client.go b/pkg/kube/client.go
index a8023516a..88456ca23 100644
--- a/pkg/kube/client.go
+++ b/pkg/kube/client.go
@@ -1204,7 +1204,7 @@ func (c *Client) Logger() *slog.Logger {
 	if lg := c.logger.Load(); lg != nil {
 		return lg
 	}
-	return slog.Default() // We rarely get here, just be defensive
+	return slog.Default() // We rarely get here, just being defensive
 }
 
 func (c *Client) SetLogger(newLogger *slog.Logger) {
diff --git a/pkg/storage/driver/cfgmaps.go b/pkg/storage/driver/cfgmaps.go
index e9093b8aa..73934a94b 100644
--- a/pkg/storage/driver/cfgmaps.go
+++ b/pkg/storage/driver/cfgmaps.go
@@ -287,7 +287,7 @@ func (cfgmaps *ConfigMaps) Logger() *slog.Logger {
 	if lg := cfgmaps.logger.Load(); lg != nil {
 		return lg
 	}
-	return slog.Default() // We rarely get here, just be defensive
+	return slog.Default() // We rarely get here, just being defensive
 }
 
 func (cfgmaps *ConfigMaps) SetLogger(newLogger *slog.Logger) {
diff --git a/pkg/storage/driver/memory.go b/pkg/storage/driver/memory.go
index 7b25ef74c..ed9444260 100644
--- a/pkg/storage/driver/memory.go
+++ b/pkg/storage/driver/memory.go
@@ -258,7 +258,7 @@ func (mem *Memory) Logger() *slog.Logger {
 	if lg := mem.logger.Load(); lg != nil {
 		return lg
 	}
-	return slog.Default() // We rarely get here, just be defensive
+	return slog.Default() // We rarely get here, just being defensive
 }
 
 func (mem *Memory) SetLogger(newLogger *slog.Logger) {
diff --git a/pkg/storage/driver/secrets.go b/pkg/storage/driver/secrets.go
index 63b21cfdd..7cdddb585 100644
--- a/pkg/storage/driver/secrets.go
+++ b/pkg/storage/driver/secrets.go
@@ -284,7 +284,7 @@ func (secrets *Secrets) Logger() *slog.Logger {
 	if lg := secrets.logger.Load(); lg != nil {
 		return lg
 	}
-	return slog.Default() // We rarely get here, just be defensive
+	return slog.Default() // We rarely get here, just being defensive
 }
 
 func (secrets *Secrets) SetLogger(newLogger *slog.Logger) {
diff --git a/pkg/storage/driver/sql.go b/pkg/storage/driver/sql.go
index f02dda597..8a0c7789b 100644
--- a/pkg/storage/driver/sql.go
+++ b/pkg/storage/driver/sql.go
@@ -280,7 +280,7 @@ type SQLReleaseCustomLabelWrapper struct {
 }
 
 // NewSQL initializes a new sql driver.
-func NewSQL(connectionString string, logger *slog.Logger, namespace string) (*SQL, error) {
+func NewSQL(connectionString string, namespace string) (*SQL, error) {
 	db, err := sqlx.Connect(postgreSQLDialect, connectionString)
 	if err != nil {
 		return nil, err
@@ -296,7 +296,7 @@ func NewSQL(connectionString string, logger *slog.Logger, namespace string) (*SQ
 	}
 
 	driver.namespace = namespace
-	driver.SetLogger(logger)
+	driver.SetLogger(slog.Default())
 
 	return driver, nil
 }
@@ -712,7 +712,7 @@ func (s *SQL) Logger() *slog.Logger {
 	if lg := s.logger.Load(); lg != nil {
 		return lg
 	}
-	return slog.Default() // We rarely get here, just be defensive
+	return slog.Default() // We rarely get here, just being defensive
 }
 
 func (s *SQL) SetLogger(newLogger *slog.Logger) {
diff --git a/pkg/storage/storage.go b/pkg/storage/storage.go
index 86c5428df..290bca2ba 100644
--- a/pkg/storage/storage.go
+++ b/pkg/storage/storage.go
@@ -347,7 +347,7 @@ func (s *Storage) Logger() *slog.Logger {
 	if lg := s.logger.Load(); lg != nil {
 		return lg
 	}
-	return slog.Default() // We rarely get here, just be defensive
+	return slog.Default() // We rarely get here, just being defensive
 }
 
 func (s *Storage) SetLogger(newLogger *slog.Logger) {