diff --git a/pkg/action/install_test.go b/pkg/action/install_test.go index 5bc3ea123..310ea86ca 100644 --- a/pkg/action/install_test.go +++ b/pkg/action/install_test.go @@ -502,7 +502,7 @@ func TestInstallRelease_DryRunServerValidation(t *testing.T) { is.NoError(err) res, err := releaserToV1Release(resi) is.NoError(err) - is.Equal(res.Info.Description, "Dry run complete") + is.Equal("Dry run complete", res.Info.Description) } func TestInstallRelease_DryRunHiddenSecret(t *testing.T) { diff --git a/pkg/action/upgrade.go b/pkg/action/upgrade.go index 4cdec0b89..0ed6ab45c 100644 --- a/pkg/action/upgrade.go +++ b/pkg/action/upgrade.go @@ -417,7 +417,7 @@ func (u *Upgrade) performUpgrade(ctx context.Context, originalRelease, upgradedR return upgradedRelease, err } } - if len(u.Description) > 0 { + if u.Description != "" { upgradedRelease.Info.Description = u.Description } else { upgradedRelease.Info.Description = "Dry run complete" diff --git a/pkg/action/upgrade_test.go b/pkg/action/upgrade_test.go index c85355fee..f7b3c63c4 100644 --- a/pkg/action/upgrade_test.go +++ b/pkg/action/upgrade_test.go @@ -685,10 +685,10 @@ func TestUpgradeRelease_DryRunServerValidation(t *testing.T) { resi, err := upAction2.RunWithContext(ctx, rel2.Name, buildChart(), vals) done() - is.NoError(err) + req.NoError(err) res, err := releaserToV1Release(resi) - is.NoError(err) - is.Equal(res.Info.Description, "Dry run complete") + req.NoError(err) + is.Equal("Dry run complete", res.Info.Description) } func TestGetUpgradeServerSideValue(t *testing.T) {