From 86c5e52ac4b67e6a853eda9b94a9dba3978a7163 Mon Sep 17 00:00:00 2001 From: Martin Hickey Date: Tue, 30 Apr 2019 18:13:17 +0100 Subject: [PATCH 1/2] Fix the image field for the scaffold chart application Signed-off-by: Martin Hickey --- pkg/chartutil/create.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pkg/chartutil/create.go b/pkg/chartutil/create.go index e9e5e12e1..40021ad42 100644 --- a/pkg/chartutil/create.go +++ b/pkg/chartutil/create.go @@ -72,8 +72,9 @@ type: application version: 0.1.0 # This is the version number of the application being deployed. This version number should be -# incremented each time you make changes to the application. -appVersion: 0.1.0 +# incremented each time you make changes to the application. Depending on the application, +# 'stable' can signify the latest stable version of the application. +appVersion: stable ` const defaultValues = `# Default values for %s. @@ -211,7 +212,7 @@ spec: spec: containers: - name: {{ .Chart.Name }} - image: "{{ .Values.image.repository }}:{{ .Release.AppVersion }}" + image: "{{ .Values.image.repository }}:{{ .Chart.AppVersion }}" imagePullPolicy: {{ .Values.image.pullPolicy }} ports: - name: http From f12c2a3111db0a4bae6d3f70e3fd393a2d8e9d19 Mon Sep 17 00:00:00 2001 From: Martin Hickey Date: Thu, 2 May 2019 10:00:41 +0100 Subject: [PATCH 2/2] Change the nginx app version to a set tag Want to avoid moving tags like using 'stable'. Therefore, specify the specifc nginx version/tag. Update from comment review: - https://github.com/helm/helm/pull/5662#discussion_r280122531 Signed-off-by: Martin Hickey --- pkg/chartutil/create.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pkg/chartutil/create.go b/pkg/chartutil/create.go index 40021ad42..8bf0fbf73 100644 --- a/pkg/chartutil/create.go +++ b/pkg/chartutil/create.go @@ -72,9 +72,8 @@ type: application version: 0.1.0 # This is the version number of the application being deployed. This version number should be -# incremented each time you make changes to the application. Depending on the application, -# 'stable' can signify the latest stable version of the application. -appVersion: stable +# incremented each time you make changes to the application. +appVersion: 1.16.0 ` const defaultValues = `# Default values for %s.