From 7204d80e7161e0a5e16279601ea3c2bc8f39dbaa Mon Sep 17 00:00:00 2001 From: Arnav Nagzirkar <113314200+arnavnagzirkar@users.noreply.github.com> Date: Mon, 8 Jun 2026 21:46:49 -0700 Subject: [PATCH] test: restore previous log writer in dependency warning tests Save and restore the prior log.Writer() instead of hardcoding os.Stderr so the global logger output is not clobbered for other tests. Signed-off-by: Arnav Nagzirkar <113314200+arnavnagzirkar@users.noreply.github.com> --- internal/chart/v3/util/dependencies_test.go | 3 ++- pkg/chart/v2/util/dependencies_test.go | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/internal/chart/v3/util/dependencies_test.go b/internal/chart/v3/util/dependencies_test.go index 4f18a29f6..3e525edb0 100644 --- a/internal/chart/v3/util/dependencies_test.go +++ b/internal/chart/v3/util/dependencies_test.go @@ -615,8 +615,9 @@ func TestProcessDependencyEnabledNoSpuriousWarnings(t *testing.T) { // Capture standard log output to detect spurious warnings from CoalesceValues. var buf bytes.Buffer + oldOutput := log.Writer() log.SetOutput(&buf) - defer log.SetOutput(os.Stderr) + defer log.SetOutput(oldOutput) if err := processDependencyEnabled(parent, parent.Values, ""); err != nil { t.Fatalf("unexpected error: %v", err) diff --git a/pkg/chart/v2/util/dependencies_test.go b/pkg/chart/v2/util/dependencies_test.go index 7c24ead73..3d532c3bd 100644 --- a/pkg/chart/v2/util/dependencies_test.go +++ b/pkg/chart/v2/util/dependencies_test.go @@ -615,8 +615,9 @@ func TestProcessDependencyEnabledNoSpuriousWarnings(t *testing.T) { // Capture standard log output to detect spurious warnings from CoalesceValues. var buf bytes.Buffer + oldOutput := log.Writer() log.SetOutput(&buf) - defer log.SetOutput(os.Stderr) + defer log.SetOutput(oldOutput) if err := processDependencyEnabled(parent, parent.Values, ""); err != nil { t.Fatalf("unexpected error: %v", err)