From 716c635d4e649a807d52a13fe8d0b00405557838 Mon Sep 17 00:00:00 2001 From: Matt Farina Date: Fri, 8 May 2020 13:35:48 -0400 Subject: [PATCH] Removing the PAX header test as it is not working The PAX header test was making a WriteHeader call and ignoring the error. When writing the type TypeXHeader it was causing an error that was being silently ignored. The Go tar package cannot write this type and produces an error when one tries to. The error reads "cannot manually encode TypeXHeader, TypeGNULongName, or TypeGNULongLink headers" Signed-off-by: Matt Farina --- pkg/chart/loader/archive_test.go | 26 -------------------------- 1 file changed, 26 deletions(-) diff --git a/pkg/chart/loader/archive_test.go b/pkg/chart/loader/archive_test.go index 7d8c8b51e..32dc315c0 100644 --- a/pkg/chart/loader/archive_test.go +++ b/pkg/chart/loader/archive_test.go @@ -59,32 +59,6 @@ func TestLoadArchiveFiles(t *testing.T) { t.Fatalf(`got unwanted error [%#v] for tar file with pax_global_header content`, err) } - if len(files) != 1 { - t.Fatalf(`expected to get one file but got [%v]`, files) - } - }, - }, - { - name: "should ignore files with TypeXHeader type", - generate: func(w *tar.Writer) { - // simulate the presence of a `pax_header` file like you might get when - // processing a GitHub release archive. - _ = w.WriteHeader(&tar.Header{ - Typeflag: tar.TypeXHeader, - Name: "pax_header", - }) - - // we need to have at least one file, otherwise we'll get the "no files in chart archive" error - _ = w.WriteHeader(&tar.Header{ - Typeflag: tar.TypeReg, - Name: "dir/empty", - }) - }, - check: func(t *testing.T, files []*BufferedFile, err error) { - if err != nil { - t.Fatalf(`got unwanted error [%#v] for tar file with pax_header content`, err) - } - if len(files) != 1 { t.Fatalf(`expected to get one file but got [%v]`, files) }