From 6cf4b8703fab9f77bb9d37a9bf4fac09f09d9e0d Mon Sep 17 00:00:00 2001 From: Joschka Tillmanns Date: Wed, 3 Apr 2019 13:52:12 +0200 Subject: [PATCH] don't do multiple chart reads on upgrade Signed-off-by: Joschka Tillmanns --- cmd/helm/upgrade.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/cmd/helm/upgrade.go b/cmd/helm/upgrade.go index 044ec045d..bc4ec5ad9 100644 --- a/cmd/helm/upgrade.go +++ b/cmd/helm/upgrade.go @@ -248,7 +248,8 @@ func (u *upgradeCmd) run() error { } // Check chart requirements to make sure all dependencies are present in /charts - if ch, err := chartutil.Load(chartPath); err == nil { + ch, err := chartutil.Load(chartPath) + if err == nil { if req, err := chartutil.LoadRequirements(ch); err == nil { if err := renderutil.CheckDependencies(ch, req); err != nil { return err @@ -260,9 +261,9 @@ func (u *upgradeCmd) run() error { return prettyError(err) } - resp, err := u.client.UpdateRelease( + resp, err := u.client.UpdateReleaseFromChart( u.release, - chartPath, + ch, helm.UpdateValueOverrides(rawVals), helm.UpgradeDryRun(u.dryRun), helm.UpgradeRecreate(u.recreate),