Avoid to call 'go' with empty -tags argument

go1.10.1 linux/amd64 complains: flag provided but not defined: -tags when compiling with: "make build-cross dist". This seems to fix it.
7 years ago · 6b2384f8b4
parent 4d519a741d
commit 6b2384f8b4
1 changed files with 1 additions and 1 deletions
--- a/2
+++ b/2
@ -31,7 +31,7 @@ build:
 .PHONY: build-cross
 build-cross: LDFLAGS += -extldflags "-static"
 build-cross:
-	CGO_ENABLED=0 gox -parallel=3 -output="_dist/{{.OS}}-{{.Arch}}/{{.Dir}}" -osarch='$(TARGETS)' $(GOFLAGS) -tags '$(TAGS)' -ldflags '$(LDFLAGS)' k8s.io/helm/cmd/$(APP)
+	CGO_ENABLED=0 gox -parallel=3 -output="_dist/{{.OS}}-{{.Arch}}/{{.Dir}}" -osarch='$(TARGETS)' $(GOFLAGS) $(if $(TAGS),-tags '$(TAGS)',) -ldflags '$(LDFLAGS)' k8s.io/helm/cmd/$(APP)

 .PHONY: dist
 dist: