From 6a00fee7abef93379a4c8a4fac83597b2ac9d7bc Mon Sep 17 00:00:00 2001 From: Julian Siebert Date: Tue, 30 Jun 2026 09:40:12 +0200 Subject: [PATCH] Apply Copilot suggestion to avoid confusion in doc Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Julian Siebert --- internal/chart/v3/util/dependencies.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/internal/chart/v3/util/dependencies.go b/internal/chart/v3/util/dependencies.go index e28288663..dd778d1d3 100644 --- a/internal/chart/v3/util/dependencies.go +++ b/internal/chart/v3/util/dependencies.go @@ -216,11 +216,11 @@ Loop: // recursively call self to process sub dependencies for _, t := range cd { // When a dependency uses an alias, cvals[path][alias] may be missing keys - // that were coalesced into cvals[originalName] by ancestor CoalesceValues - // calls (which used the original chart name, not the alias). To correct - // this, we backfill any missing keys from the top-level entry into the - // nested path entry. The nested entry is authoritative: if a key exists - // in both, the nested (alias-keyed) value wins. + // that were instead placed in cvals[t.Metadata.Name] at the current values root by + // earlier CoalesceValues calls (which coalesce against the full values tree, not the + // path-scoped subtable). Backfill any missing keys into the path-scoped entry so + // condition checks see chart defaults; path-scoped values remain authoritative and + // win on conflicts. if path != "" { if pt, err := cvals.Table(strings.TrimSuffix(path, ".")); err == nil { if top, ok := cvals[t.Metadata.Name].(map[string]interface{}); ok {