From 68ca556162f72a89940e1f09f88bcae4c61dd78c Mon Sep 17 00:00:00 2001 From: Matthew Fisher Date: Mon, 10 Sep 2018 10:33:17 -0700 Subject: [PATCH] add unit test for race condition in `helm list` Signed-off-by: Matthew Fisher --- pkg/tiller/release_list_test.go | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/pkg/tiller/release_list_test.go b/pkg/tiller/release_list_test.go index b9ab6fe55..f2d19cf96 100644 --- a/pkg/tiller/release_list_test.go +++ b/pkg/tiller/release_list_test.go @@ -274,3 +274,26 @@ func TestReleasesNamespace(t *testing.T) { t.Errorf("Expected 2 releases, got %d", len(mrs.val.Releases)) } } + +func TestReleasePartition(t *testing.T) { + var rl []*release.Release + rs := rsFixture() + rs.Log = t.Logf + num := 7 + for i := 0; i < num; i++ { + rel := releaseStub() + rel.Name = fmt.Sprintf("rel-%d", i) + rl = append(rl, rel) + } + visited := map[string]bool{} + + chunks := rs.partition(rl, 0) + for chunk := range chunks { + for _, rel := range chunk { + if visited[rel.Name] { + t.Errorf("%s was already visited", rel.Name) + } + visited[rel.Name] = true + } + } +}