From b9d3974df0d5130ca9d0c272ca63b14ee8ce0a46 Mon Sep 17 00:00:00 2001 From: carlory Date: Mon, 18 Sep 2017 15:38:35 +0800 Subject: [PATCH 1/4] fix func comment --- pkg/chartutil/files.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/chartutil/files.go b/pkg/chartutil/files.go index 6ce619e89..01ebcc8d7 100644 --- a/pkg/chartutil/files.go +++ b/pkg/chartutil/files.go @@ -183,7 +183,7 @@ func ToYaml(v interface{}) string { // This is not a general-purpose YAML parser, and will not parse all valid // YAML documents. Additionally, because its intended use is within templates // it tolerates errors. It will insert the returned error message string into -// m["error"] in the returned map. +// m["Error"] in the returned map. func FromYaml(str string) map[string]interface{} { m := map[string]interface{}{} From ad2d8e434a3cf18d1c75699f1fae73c47c613c03 Mon Sep 17 00:00:00 2001 From: carlory Date: Mon, 18 Sep 2017 15:46:36 +0800 Subject: [PATCH 2/4] fix fromjson comment --- pkg/chartutil/files.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/chartutil/files.go b/pkg/chartutil/files.go index 01ebcc8d7..687a9a8d6 100644 --- a/pkg/chartutil/files.go +++ b/pkg/chartutil/files.go @@ -225,7 +225,7 @@ func ToJson(v interface{}) string { // This is not a general-purpose JSON parser, and will not parse all valid // YAML documents. Additionally, because its intended use is within templates // it tolerates errors. It will insert the returned error message string into -// m["error"] in the returned map. +// m["Error"] in the returned map. func FromJson(str string) map[string]interface{} { m := map[string]interface{}{} From 48cb6ad63e995f8d2f2143848d9ddddc374d10d0 Mon Sep 17 00:00:00 2001 From: Sean Slattery Date: Mon, 18 Sep 2017 11:46:56 -0700 Subject: [PATCH 3/4] Minor Spelling Corrections --- docs/charts_hooks.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/charts_hooks.md b/docs/charts_hooks.md index 92c50e20c..5fc9462e4 100644 --- a/docs/charts_hooks.md +++ b/docs/charts_hooks.md @@ -87,7 +87,7 @@ in the future.) It is considered good practice to add a hook weight, and set it to `0` if weight is not important. -### Hook resources are not managed with correponding releases +### Hook resources are not managed with corresponding releases The resources that a hook creates are not tracked or managed as part of the release. Once Tiller verifies that the hook has reached its ready state, it @@ -180,5 +180,4 @@ It is also possible to define policies that determine when to delete correspondi "helm.sh/hook-delete-policy": hook-succeeded ``` -When using `"helm.sh/hook-delete-policy"` annoation, you can choose its value from `"hook-succeeded"` and `"hook-failed"`. The value `"hook-succeeded"` specifies Tiller should delete the hook after the hook is successfully excuted, while the value `"hook-failed"`specifies Tiller should delete the hook if the hook is failed during execuation. - +When using `"helm.sh/hook-delete-policy"` annotation, you can choose its value from `"hook-succeeded"` and `"hook-failed"`. The value `"hook-succeeded"` specifies Tiller should delete the hook after the hook is successfully executed, while the value `"hook-failed"`specifies Tiller should delete the hook if the hook failed during execution. From 0089a28dba6a4fbd4e750e1da04d32d6897cb2f4 Mon Sep 17 00:00:00 2001 From: Joshua Dolitsky Date: Tue, 19 Sep 2017 18:18:25 -0500 Subject: [PATCH 4/4] Add ChartMuseum to related.md --- docs/related.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/related.md b/docs/related.md index c450e2607..73db34829 100644 --- a/docs/related.md +++ b/docs/related.md @@ -57,6 +57,7 @@ Tools layered on top of Helm or Tiller. - [Monocular](https://github.com/helm/monocular) - Web UI for Helm Chart repositories - [Helm Chart Publisher](https://github.com/luizbafilho/helm-chart-publisher) - HTTP API for publishing Helm Charts in an easy way - [Armada](https://github.com/att-comdev/armada) - Manage prefixed releases throughout various Kubernetes namespaces, and removes completed jobs for complex deployments. Used by the [Openstack-Helm](https://github.com/openstack/openstack-helm) team. +- [ChartMuseum](https://github.com/chartmuseum/chartmuseum) - Helm Chart Repository with support for Amazon S3 and Google Cloud Storage ## Helm Included