From 6230cb94a920676232ad56490a89b32c422720bb Mon Sep 17 00:00:00 2001 From: Li Zhijian Date: Wed, 14 Oct 2020 17:10:46 +0800 Subject: [PATCH] testing: Don't cleanup tempfiles if the test failed As suggestion by Paul Brousseau, It might be useful to leave the directory in place if the test fails. Signed-off-by: Li Zhijian --- internal/test/ensure/ensure.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/internal/test/ensure/ensure.go b/internal/test/ensure/ensure.go index f15098797..569024467 100644 --- a/internal/test/ensure/ensure.go +++ b/internal/test/ensure/ensure.go @@ -45,7 +45,11 @@ func TempDir(t *testing.T) string { if err != nil { t.Fatal(err) } - t.Cleanup(func() { os.RemoveAll(d) }) + t.Cleanup(func() { + if !t.Failed() { + os.RemoveAll(d) + } + }) return d }