From 608fd7318a1637de7ee0e161906861e8e2184b30 Mon Sep 17 00:00:00 2001 From: DoctorZK Date: Wed, 30 Aug 2017 15:01:54 +0800 Subject: [PATCH] fix(tiller): fix a warning bug in hook annotation --- pkg/tiller/hooks.go | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/pkg/tiller/hooks.go b/pkg/tiller/hooks.go index 8d72f95cf..741913f22 100644 --- a/pkg/tiller/hooks.go +++ b/pkg/tiller/hooks.go @@ -171,17 +171,18 @@ func (file *manifestFile) sort(result *result) error { DeletePolicies: []release.Hook_DeletePolicy{}, } - isKnownHook := false + isUnknownHook := false for _, hookType := range strings.Split(hookTypes, ",") { hookType = strings.ToLower(strings.TrimSpace(hookType)) e, ok := events[hookType] - if ok { - isKnownHook = true - h.Events = append(h.Events, e) + if !ok { + isUnknownHook = true + break } + h.Events = append(h.Events, e) } - if !isKnownHook { + if isUnknownHook { log.Printf("info: skipping unknown hook: %q", hookTypes) continue }