From 5dfbf7e3cbf0aec02ef0c13c90140b3e5057a961 Mon Sep 17 00:00:00 2001 From: Matt Butcher Date: Wed, 26 Oct 2016 16:54:20 -0600 Subject: [PATCH] fix(helm): fail when helm deps are not fetched This changes the behavior of the bulk downloader to fail as soon as it encounters a dependency that it cannot fetch. Closes #1439 --- cmd/helm/downloader/manager.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cmd/helm/downloader/manager.go b/cmd/helm/downloader/manager.go index 731a9b3ea..82ab83ad5 100644 --- a/cmd/helm/downloader/manager.go +++ b/cmd/helm/downloader/manager.go @@ -194,15 +194,15 @@ func (m *Manager) downloadAll(deps []*chartutil.Dependency) error { for _, dep := range deps { fmt.Fprintf(m.Out, "Downloading %s from repo %s\n", dep.Name, dep.Repository) + // Any failure to resolve/download a chart should fail: + // https://github.com/kubernetes/helm/issues/1439 churl, err := findChartURL(dep.Name, dep.Version, dep.Repository, repos) if err != nil { - fmt.Fprintf(m.Out, "WARNING: %s (skipped)", err) - continue + return fmt.Errorf("could not find %s: %s", churl, err) } if _, _, err := dl.DownloadTo(churl, "", destPath); err != nil { - fmt.Fprintf(m.Out, "WARNING: Could not download %s: %s (skipped)", churl, err) - continue + return fmt.Errorf("could not download %s: %s", churl, err) } } return nil