From da989dc275a92fd48343263baf99231b310ce9ac Mon Sep 17 00:00:00 2001 From: Arash Deshmeh Date: Wed, 14 Feb 2018 09:09:35 -0500 Subject: [PATCH] fix(helm): fix the bug in test code 'cmd/helm/init_test.go' and 'cmd/helm/repo_update_test.go' that leave behind temporary helm home directories during build. With this fix, the build process no longer leaves behind 'helm_home-*' temp directories. Signed-off-by: Arash Deshmeh --- cmd/helm/init_test.go | 8 ++++---- cmd/helm/repo_update_test.go | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cmd/helm/init_test.go b/cmd/helm/init_test.go index 4513315b7..6a5767fca 100644 --- a/cmd/helm/init_test.go +++ b/cmd/helm/init_test.go @@ -46,7 +46,7 @@ func TestInitCmd(t *testing.T) { if err != nil { t.Fatal(err) } - defer os.Remove(home) + defer os.RemoveAll(home) var buf bytes.Buffer fc := fake.NewSimpleClientset() @@ -80,7 +80,7 @@ func TestInitCmd_exists(t *testing.T) { if err != nil { t.Fatal(err) } - defer os.Remove(home) + defer os.RemoveAll(home) var buf bytes.Buffer fc := fake.NewSimpleClientset(&v1beta1.Deployment{ @@ -113,7 +113,7 @@ func TestInitCmd_clientOnly(t *testing.T) { if err != nil { t.Fatal(err) } - defer os.Remove(home) + defer os.RemoveAll(home) var buf bytes.Buffer fc := fake.NewSimpleClientset() @@ -184,7 +184,7 @@ func TestEnsureHome(t *testing.T) { if err != nil { t.Fatal(err) } - defer os.Remove(home) + defer os.RemoveAll(home) b := bytes.NewBuffer(nil) hh := helmpath.Home(home) diff --git a/cmd/helm/repo_update_test.go b/cmd/helm/repo_update_test.go index e6f2af32f..68f964f32 100644 --- a/cmd/helm/repo_update_test.go +++ b/cmd/helm/repo_update_test.go @@ -37,7 +37,7 @@ func TestUpdateCmd(t *testing.T) { cleanup := resetEnv() defer func() { - os.Remove(thome.String()) + os.RemoveAll(thome.String()) cleanup() }()