feat(lint): allow files starting with _ to be skipped

Signed-off-by: Daksh Sangal <134773611+Qu-Ack@users.noreply.github.com>

internal/chart/v3/lint/rules/template.go

@@ -220,6 +220,13 @@ func validateTemplatesDir(templatesPath string) error {
 }
 
 func validateAllowedExtension(fileName string) error {
+	baseName := filepath.Base(fileName)
+
+	if strings.HasPrefix(baseName, "_") {
+		fmt.Println("skipping _ files")
+		return nil
+	}
+
 	ext := filepath.Ext(fileName)
 	validExtensions := []string{".yaml", ".yml", ".tpl", ".txt"}
 

internal/chart/v3/lint/rules/template_test.go

@@ -32,14 +32,14 @@ import (
 const templateTestBasedir = "./testdata/albatross"
 
 func TestValidateAllowedExtension(t *testing.T) {
-	var failTest = []string{"/foo", "/test.toml"}
+	var failTest = []string{"/foo", "/test.toml", "regular.json"}
 	for _, test := range failTest {
 		err := validateAllowedExtension(test)
 		if err == nil || !strings.Contains(err.Error(), "Valid extensions are .yaml, .yml, .tpl, or .txt") {
 			t.Errorf("validateAllowedExtension('%s') to return \"Valid extensions are .yaml, .yml, .tpl, or .txt\", got no error", test)
 		}
 	}
-	var successTest = []string{"/foo.yaml", "foo.yaml", "foo.tpl", "/foo/bar/baz.yaml", "NOTES.txt"}
+	var successTest = []string{"/foo.yaml", "foo.yaml", "foo.tpl", "/foo/bar/baz.yaml", "NOTES.txt", "_envoy.json"}
 	for _, test := range successTest {
 		err := validateAllowedExtension(test)
 		if err != nil {

pkg/chart/v2/lint/rules/template.go

@@ -220,6 +220,12 @@ func validateTemplatesDir(templatesPath string) error {
 }
 
 func validateAllowedExtension(fileName string) error {
+	baseName := filepath.Base(fileName)
+
+	if strings.HasPrefix(baseName, "_") {
+		return nil
+	}
+
 	ext := filepath.Ext(fileName)
 	validExtensions := []string{".yaml", ".yml", ".tpl", ".txt"}
 

pkg/chart/v2/lint/rules/template_test.go

@@ -32,14 +32,14 @@ import (
 const templateTestBasedir = "./testdata/albatross"
 
 func TestValidateAllowedExtension(t *testing.T) {
-	var failTest = []string{"/foo", "/test.toml"}
+	var failTest = []string{"/foo", "/test.toml", "regular.json"}
 	for _, test := range failTest {
 		err := validateAllowedExtension(test)
 		if err == nil || !strings.Contains(err.Error(), "Valid extensions are .yaml, .yml, .tpl, or .txt") {
 			t.Errorf("validateAllowedExtension('%s') to return \"Valid extensions are .yaml, .yml, .tpl, or .txt\", got no error", test)
 		}
 	}
-	var successTest = []string{"/foo.yaml", "foo.yaml", "foo.tpl", "/foo/bar/baz.yaml", "NOTES.txt"}
+	var successTest = []string{"/foo.yaml", "foo.yaml", "foo.tpl", "/foo/bar/baz.yaml", "NOTES.txt", "_regular.json"}
 	for _, test := range successTest {
 		err := validateAllowedExtension(test)
 		if err != nil {