From 5bad262d9836dd02241adab4dd9250723a75a513 Mon Sep 17 00:00:00 2001
From: Amir Saeid <amir@glgdgt.com>
Date: Wed, 30 May 2018 15:59:12 +0100
Subject: [PATCH] Remove tempfile if necessary and chmod destfile

---
 pkg/downloader/chart_downloader.go | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/pkg/downloader/chart_downloader.go b/pkg/downloader/chart_downloader.go
index 57d8459af..be42c3bf9 100644
--- a/pkg/downloader/chart_downloader.go
+++ b/pkg/downloader/chart_downloader.go
@@ -98,10 +98,20 @@ func (c *ChartDownloader) DownloadTo(ref, version, dest string) (string, *proven
 	name := filepath.Base(u.Path)
 	destfile := filepath.Join(dest, name)
 	tmpfile, err := ioutil.TempFile(dest, "tmp")
+	// Remove the temp file in case an error occurred before renaming.
+	defer func() {
+		if tmpfile != nil {
+			if _, err := os.Stat(tmpfile.Name()); err == nil {
+				os.Remove(tmpfile.Name())
+			}
+		}
+	}()
 	if err != nil {
 		return "", nil, err
 	}
+
 	tmpfilename := tmpfile.Name()
+	// 0644 here is ineffective since TempFile creates files with 0600 permission. We'll chmod it later.
 	if err := ioutil.WriteFile(tmpfilename, data.Bytes(), 0644); err != nil {
 		return tmpfilename, nil, err
 	}
@@ -110,6 +120,10 @@ func (c *ChartDownloader) DownloadTo(ref, version, dest string) (string, *proven
 		return destfile, nil, err
 	}
 
+	if err := os.Chmod(destfile, 0644); err != nil {
+		return destfile, nil, err
+	}
+
 	// If provenance is requested, verify it.
 	ver := &provenance.Verification{}
 	if c.Verify > VerifyNever {