From 5aae094f2588536bec2fde604a46a0308ca21d69 Mon Sep 17 00:00:00 2001 From: Renato Suero Date: Wed, 1 Jul 2020 13:02:54 +0200 Subject: [PATCH] change the DNS name limit Signed-off-by: Renato Suero --- pkg/action/install.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/action/install.go b/pkg/action/install.go index 00fb208b0..00ffbf5d2 100644 --- a/pkg/action/install.go +++ b/pkg/action/install.go @@ -52,10 +52,10 @@ import ( // releaseNameMaxLen is the maximum length of a release name. // -// As of Kubernetes 1.4, the max limit on a name is 63 chars. We reserve 10 for -// charts to add data. Effectively, that gives us 53 chars. -// See https://github.com/helm/helm/issues/1528 -const releaseNameMaxLen = 53 +// As of Kubernetes 1.18, the max limit on a name is 253 chars. We reserve 10 for +// charts to add data. Effectively, that gives us 231 chars. +// See https://github.com/helm/helm/issues/6006#issuecomment-652291971 +const releaseNameMaxLen = 231 // NOTESFILE_SUFFIX that we want to treat special. It goes through the templating engine // but it's not a yaml file (resource) hence can't have hooks, etc. And the user actually