Merge pull request #649 from technosophos/feat/helm-delete-k8s

feat(tiller): delete operation runs against Kubernetes

cmd/helm/remove.go

@@ -39,7 +39,7 @@ func rmRelease(cmd *cobra.Command, args []string) error {
 
 	// TODO: Handle dry run use case.
 	if removeDryRun {
-		fmt.Printf("Deleting %s\n", args[0])
+		fmt.Printf("DRY RUN: Deleting %s\n", args[0])
 		return nil
 	}
 

cmd/tiller/environment/environment.go

@@ -128,11 +128,15 @@ type KubeClient interface {
 	//
 	// reader must contain a YAML stream (one or more YAML documents separated
 	// by "\n---\n").
-	//
-	// config is optional. If nil, the client will use its existing configuration.
-	// If set, the client will override its default configuration with the
-	// passed in one.
 	Create(namespace string, reader io.Reader) error
+
+	// Delete destroys one or more resources.
+	//
+	// namespace must contain a valid existing namespace.
+	//
+	// reader must contain a YAML stream (one or more YAML documents separated
+	// by "\n---\n").
+	Delete(namespace string, reader io.Reader) error
 }
 
 // PrintingKubeClient implements KubeClient, but simply prints the reader to
@@ -146,6 +150,10 @@ func (p *PrintingKubeClient) Create(ns string, r io.Reader) error {
 	_, err := io.Copy(p.Out, r)
 	return err
 }
+func (p *PrintingKubeClient) Delete(ns string, r io.Reader) error {
+	_, err := io.Copy(p.Out, r)
+	return err
+}
 
 // Environment provides the context for executing a client request.
 //

cmd/tiller/environment/environment_test.go

@@ -53,6 +53,9 @@ type mockKubeClient struct {
 func (k *mockKubeClient) Create(ns string, r io.Reader) error {
 	return nil
 }
+func (k *mockKubeClient) Delete(ns string, r io.Reader) error {
+	return nil
+}
 
 var _ Engine = &mockEngine{}
 var _ ReleaseStorage = &mockReleaseStorage{}

cmd/tiller/release_server.go

@@ -207,8 +207,12 @@ func (s *releaseServer) UninstallRelease(c ctx.Context, req *services.UninstallR
 	rel.Info.Status.Code = release.Status_DELETED
 	rel.Info.Deleted = timeconv.Now()
 
-	// TODO: Once KubeClient is ready, delete the resources.
-	log.Println("WARNING: Currently not deleting resources from k8s")
+	b := bytes.NewBuffer([]byte(rel.Manifest))
+
+	if err := s.env.KubeClient.Delete(s.env.Namespace, b); err != nil {
+		log.Printf("uninstall: Failed deletion of %q: %s", req.Name, err)
+		return nil, err
+	}
 
 	if err := s.env.Releases.Update(rel); err != nil {
 		log.Printf("uninstall: Failed to store updated release: %s", err)

docs/examples/alpine/templates/alpine-pod.yaml

@@ -5,9 +5,9 @@ metadata:
   labels:
     heritage: {{.Release.Service}}
     chartName: {{.Chart.Name}}
-    chartVersion: {{.Chart.Version}}
+    chartVersion: {{.Chart.Version | quote}}
   annotations:
-    "helm.sh/created": {{.Release.Time.Seconds}}
+    "helm.sh/created": "{{.Release.Time.Seconds}}"
 spec:
   restartPolicy: {{default "Never" .restart_policy}}
   containers: