From ef538906eaca18de86adb4575ddb5f4842d51f2f Mon Sep 17 00:00:00 2001 From: jackgr Date: Mon, 7 Mar 2016 15:05:10 -0800 Subject: [PATCH 1/2] Fix TAG value --- expandybird/Makefile | 3 ++- include.mk | 3 ++- manager/Makefile | 3 ++- resourcifier/Makefile | 3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/expandybird/Makefile b/expandybird/Makefile index 16f0c7882..c1c26c08e 100644 --- a/expandybird/Makefile +++ b/expandybird/Makefile @@ -31,7 +31,8 @@ else endif container: - docker build -t $(PREFIX)/$(IMAGE):$(TAG) -f Dockerfile $(DIR) + docker build -t $(PREFIX)/$(IMAGE):latest -f Dockerfile $(DIR) + docker tag -f $(PREFIX)/$(IMAGE):latest $(PREFIX)/$(IMAGE):$(TAG) clean: -docker rmi $(PREFIX)/$(IMAGE):$(TAG) diff --git a/include.mk b/include.mk index fca436983..36c1e1df6 100644 --- a/include.mk +++ b/include.mk @@ -5,7 +5,8 @@ info: @echo "Project: ${PROJECT}" @echo "Image: ${IMAGE}" -TAG ?= $(shell echo `date +"%s"`_`date +"%N"`) +DEFAULT_TAG := git-$(shell git rev-parse --short HEAD) +TAG ?= ${DEFAULT_TAG} .PHONY: test-unit test-unit: diff --git a/manager/Makefile b/manager/Makefile index 209c874f2..325e82a08 100644 --- a/manager/Makefile +++ b/manager/Makefile @@ -31,7 +31,8 @@ else endif container: - docker build -t $(PREFIX)/$(IMAGE):$(TAG) -f Dockerfile $(DIR) + docker build -t $(PREFIX)/$(IMAGE):latest -f Dockerfile $(DIR) + docker tag -f $(PREFIX)/$(IMAGE):latest $(PREFIX)/$(IMAGE):$(TAG) clean: -docker rmi $(PREFIX)/$(IMAGE):$(TAG) diff --git a/resourcifier/Makefile b/resourcifier/Makefile index 9d6eebe1a..e3cdd410c 100644 --- a/resourcifier/Makefile +++ b/resourcifier/Makefile @@ -33,7 +33,8 @@ else endif container: - docker build -t $(PREFIX)/$(IMAGE):$(TAG) -f Dockerfile $(DIR) + docker build -t $(PREFIX)/$(IMAGE):latest -f Dockerfile $(DIR) + docker tag -f $(PREFIX)/$(IMAGE):latest $(PREFIX)/$(IMAGE):$(TAG) clean: -docker rmi $(PREFIX)/$(IMAGE):$(TAG) From df5b61856069ebcdc27df1b9a6ee22de63595a92 Mon Sep 17 00:00:00 2001 From: jackgr Date: Mon, 7 Mar 2016 18:24:08 -0800 Subject: [PATCH 2/2] Update release label in build scripts --- get-install.sh | 2 +- hack/dm-push.sh | 2 +- install.yaml | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/get-install.sh b/get-install.sh index df53665ef..b8c2d59ca 100755 --- a/get-install.sh +++ b/get-install.sh @@ -15,7 +15,7 @@ set -euo pipefail -DEFAULT_TAG=v1.2 +DEFAULT_TAG=v1.2.1 DEFAULT_BINARY=${GOPATH}/bin/dm DEFAULT_PLATFORM=$(uname | tr '[:upper:]' '[:lower:]') DEFAULT_ARCH=$(uname -m) diff --git a/hack/dm-push.sh b/hack/dm-push.sh index 8484f7fe0..dff48455f 100755 --- a/hack/dm-push.sh +++ b/hack/dm-push.sh @@ -21,7 +21,7 @@ set -euo pipefail -DEFAULT_TAG=v1.2 +DEFAULT_TAG=v1.2.1 DEFAULT_BINARY=${GOPATH}/bin/dm DEFAULT_PLATFORM=$(uname | tr '[:upper:]' '[:lower:]') DEFAULT_ARCH=$(uname -m) diff --git a/install.yaml b/install.yaml index 69a21a54e..ac96c5777 100644 --- a/install.yaml +++ b/install.yaml @@ -58,7 +58,7 @@ spec: spec: containers: - env: [] - image: gcr.io/dm-k8s-prod/expandybird:v1.2 + image: gcr.io/dm-k8s-prod/expandybird:v1.2.1 name: expandybird ports: - containerPort: 8080 @@ -102,7 +102,7 @@ spec: spec: containers: - env: [] - image: gcr.io/dm-k8s-prod/resourcifier:v1.2 + image: gcr.io/dm-k8s-prod/resourcifier:v1.2.1 imagePullPolicy: Always livenessProbe: httpGet: @@ -153,7 +153,7 @@ spec: spec: containers: - env: [] - image: gcr.io/dm-k8s-prod/manager:v1.2 + image: gcr.io/dm-k8s-prod/manager:v1.2.1 imagePullPolicy: Always livenessProbe: httpGet: