From 56e52d139c27b43397c567ecc31aea1ce0e73b5d Mon Sep 17 00:00:00 2001 From: Simon Alling Date: Tue, 12 Apr 2022 13:58:10 +0200 Subject: [PATCH] Fix confusing test failure message Resolves #10466. Signed-off-by: Simon Alling --- cmd/helm/helm_test.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/cmd/helm/helm_test.go b/cmd/helm/helm_test.go index 2cf3e897d..1adcf016f 100644 --- a/cmd/helm/helm_test.go +++ b/cmd/helm/helm_test.go @@ -60,8 +60,11 @@ func runTestCmd(t *testing.T, tests []cmdTestCase) { } t.Logf("running cmd (attempt %d): %s", i+1, tt.cmd) _, out, err := executeActionCommandC(storage, tt.cmd) - if (err != nil) != tt.wantError { - t.Errorf("expected error, got '%v'", err) + if tt.wantError && err == nil { + t.Errorf("expected error, got success with the following output:\n%s", out) + } + if !tt.wantError && err != nil { + t.Errorf("expected no error, got: '%v'", err) } if tt.golden != "" { test.AssertGoldenString(t, out, tt.golden)