From 15daced2416e8ca7d5f52134b0d2608998de2db1 Mon Sep 17 00:00:00 2001 From: "fengyun.pan" Date: Thu, 11 May 2017 18:48:18 +0800 Subject: [PATCH 1/2] Return err when failed to check dependencie and save chart --- cmd/helm/package.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/cmd/helm/package.go b/cmd/helm/package.go index a558c40f0..38bb5200e 100644 --- a/cmd/helm/package.go +++ b/cmd/helm/package.go @@ -130,6 +130,10 @@ func (p *packageCmd) run(cmd *cobra.Command, args []string) error { if err := checkDependencies(ch, reqs, p.out); err != nil { return err } + } else { + if err != chartutil.ErrRequirementsNotFound { + return err + } } var dest string @@ -147,6 +151,8 @@ func (p *packageCmd) run(cmd *cobra.Command, args []string) error { name, err := chartutil.Save(ch, dest) if err == nil { debug("Saved %s to current directory\n", name) + } else { + return fmt.Errorf("Failed to save: %s", err) } // Save to $HELM_HOME/local directory. This is second, because we don't want From 346c82952d1a5ef13ffd5cb30b4a019c44628785 Mon Sep 17 00:00:00 2001 From: "fengyun.pan" Date: Mon, 15 May 2017 09:36:49 +0800 Subject: [PATCH 2/2] Add friendly output for helm package --- cmd/helm/package.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/helm/package.go b/cmd/helm/package.go index 38bb5200e..9ca853ad3 100644 --- a/cmd/helm/package.go +++ b/cmd/helm/package.go @@ -150,7 +150,7 @@ func (p *packageCmd) run(cmd *cobra.Command, args []string) error { name, err := chartutil.Save(ch, dest) if err == nil { - debug("Saved %s to current directory\n", name) + fmt.Fprintf(p.out, "Successfully packaged chart and saved it to: %s\n", name) } else { return fmt.Errorf("Failed to save: %s", err) } @@ -162,7 +162,7 @@ func (p *packageCmd) run(cmd *cobra.Command, args []string) error { if err := repo.AddChartToLocalRepo(ch, lr); err != nil { return err } - debug("Saved %s to %s\n", name, lr) + debug("Successfully saved %s to %s\n", name, lr) } if p.sign {