From 09d78c17ce7925ae630e7a147c2e50ab1840ba18 Mon Sep 17 00:00:00 2001 From: sarfraj89 Date: Fri, 9 Jan 2026 00:34:01 +0530 Subject: [PATCH 1/4] Add ShellCheck GitHub Action for bash scripts Signed-off-by: sarfraj89 --- .github/workflows/shellcheck.yml | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 .github/workflows/shellcheck.yml diff --git a/.github/workflows/shellcheck.yml b/.github/workflows/shellcheck.yml new file mode 100644 index 000000000..261cddc41 --- /dev/null +++ b/.github/workflows/shellcheck.yml @@ -0,0 +1,28 @@ +name: ShellCheck + +on: + workflow_dispatch: + pull_request: + push: + branches: + - main + paths: + - '**.sh' + - '.github/workflows/shellcheck.yml' + +permissions: + contents: read + +jobs: + shellcheck: + runs-on: ubuntu-latest + steps: + - name: Checkout code + uses: actions/checkout@v4 + + - name: Run ShellCheck + uses: ludeeus/action-shellcheck@master + + with: + scandir: scripts + severity: error From 7f1867d436175d5be79c99acfaa8978cdc57e84d Mon Sep 17 00:00:00 2001 From: sarfraj89 Date: Fri, 9 Jan 2026 23:40:10 +0530 Subject: [PATCH 2/4] Run ShellCheck directly in GitHub Actions Signed-off-by: sarfraj89 --- .github/workflows/shellcheck.yml | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/.github/workflows/shellcheck.yml b/.github/workflows/shellcheck.yml index 261cddc41..c5cbf5b03 100644 --- a/.github/workflows/shellcheck.yml +++ b/.github/workflows/shellcheck.yml @@ -1,14 +1,14 @@ -name: ShellCheck +name: Lint Bash Scripts on: - workflow_dispatch: pull_request: + paths: + - 'scripts/**.sh' push: branches: - main paths: - - '**.sh' - - '.github/workflows/shellcheck.yml' + - 'scripts/**.sh' permissions: contents: read @@ -17,12 +17,10 @@ jobs: shellcheck: runs-on: ubuntu-latest steps: - - name: Checkout code + - name: Checkout uses: actions/checkout@v4 + with: + persist-credentials: false - name: Run ShellCheck - uses: ludeeus/action-shellcheck@master - - with: - scandir: scripts - severity: error + run: shellcheck ./scripts/**/*.sh \ No newline at end of file From 3d18a041bef90f1e175777a3d8b63824af729fea Mon Sep 17 00:00:00 2001 From: Sarfraj Khan Date: Sun, 18 Jan 2026 17:07:56 +0530 Subject: [PATCH 3/4] chore: pin actions/checkout version Signed-off-by: Sarfraj Khan --- .github/workflows/shellcheck.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/shellcheck.yml b/.github/workflows/shellcheck.yml index c5cbf5b03..ae2c93599 100644 --- a/.github/workflows/shellcheck.yml +++ b/.github/workflows/shellcheck.yml @@ -17,10 +17,10 @@ jobs: shellcheck: runs-on: ubuntu-latest steps: - - name: Checkout - uses: actions/checkout@v4 + - name: Checkout source code + uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # pin@v4.0.1 with: persist-credentials: false - name: Run ShellCheck - run: shellcheck ./scripts/**/*.sh \ No newline at end of file + run: shellcheck ./scripts/**/*.sh From 9fbb81e6d94ff43abbda6f90f3198a57c13b6230 Mon Sep 17 00:00:00 2001 From: Sarfraj Khan Date: Sun, 18 Jan 2026 22:29:56 +0530 Subject: [PATCH 4/4] Update checkout action version in shellcheck workflow Signed-off-by: Sarfraj Khan --- .github/workflows/shellcheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/shellcheck.yml b/.github/workflows/shellcheck.yml index ae2c93599..1a358730e 100644 --- a/.github/workflows/shellcheck.yml +++ b/.github/workflows/shellcheck.yml @@ -18,7 +18,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout source code - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # pin@v4.0.1 + uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # pin@v6.0.1 with: persist-credentials: false